Page MenuHomeFreeBSD
Differential D47526

swap_pager: Ensure that swapoff puts swapped-in pages in page queues
ClosedPublic
Actions

Authored by markj on Nov 12 2024, 3:02 PM.
Tags
None
Referenced Files
F174569033: D47526.diff
Sun, Oct 4, 6:25 AM
F174569026: D47526.diff
Sun, Oct 4, 6:25 AM
Unknown Object (File)
Fri, Oct 2, 5:40 PM
Unknown Object (File)
Fri, Oct 2, 10:46 AM
Unknown Object (File)
Thu, Oct 1, 12:11 AM
Unknown Object (File)
Wed, Sep 30, 11:44 PM
Unknown Object (File)
Wed, Sep 30, 11:09 PM
Unknown Object (File)
Wed, Sep 30, 7:07 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
alc
dougm
Commits
rG34182e597b2a: swap_pager: Ensure that swapoff puts swapped-in pages in page queues
rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues
Summary

Readahead/behind pages are handled by the swap pager, but the get_pages
caller is responsible for putting fetched pages into queues (or wiring
them beforehand).

Reported by: pho

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Nov 12 2024, 3:02 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 12 2024, 3:02 PM
markj requested review of this revision.Nov 12 2024, 3:02 PM
Harbormaster completed remote builds in B60502: Diff 146320.Nov 12 2024, 3:02 PM
alc added a comment.Nov 12 2024, 7:36 PM

Is this related to the KASSERT that was recently added to vm_object_terminate_single_page?

markj added a comment.Nov 12 2024, 7:50 PM
In D47526#1084075, @alc wrote:

Is this related to the KASSERT that was recently added to vm_object_terminate_single_page?

Yes, Peter was able to trigger the assertion using a swapoff test.

kib accepted this revision.Nov 12 2024, 11:21 PM
This revision is now accepted and ready to land.Nov 12 2024, 11:21 PM
alc accepted this revision.Nov 13 2024, 6:45 AM
dougm accepted this revision.Nov 13 2024, 8:11 AM
Closed by commit rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues (authored by markj). · Explain WhyNov 13 2024, 2:15 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGd11d407aee48: swap_pager: Ensure that swapoff puts swapped-in pages in page queues.
markj added a commit: rG34182e597b2a: swap_pager: Ensure that swapoff puts swapped-in pages in page queues.Nov 28 2024, 2:41 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
1 line

Diff 146354

View Options

sys/vm/swap_pager.c

Loading...