Page MenuHomeFreeBSD
Differential D47476

nanobsd: Fix parallel make
ClosedPublic
Actions

Authored by jlduran on Nov 7 2024, 6:04 PM.
Tags
None
Referenced Files
F162746355: D47476.diff
Thu, Jul 16, 11:25 AM
Unknown Object (File)
Sat, Jul 4, 12:49 PM
Unknown Object (File)
Fri, Jul 3, 7:32 AM
Unknown Object (File)
Thu, Jun 25, 3:19 PM
Unknown Object (File)
Tue, Jun 23, 11:52 AM
Unknown Object (File)
May 26 2026, 4:32 AM
Unknown Object (File)
May 25 2026, 12:08 PM
Unknown Object (File)
May 22 2026, 5:04 PM
View All Files
Subscribers
None

Details

Reviewers
imp
emaste
Commits
rG16fc83629869: nanobsd: Fix parallel make
rG67dd41cdb10d: nanobsd: Fix parallel make
rG3c5d19a40de7: nanobsd: Fix parallel make
Summary

The NANO_NCPU (number of CPUs) value gets ignored by the build script
when setting the NANO_PMAKE (parallel make) value.

Fix it by setting the NANO_PMAKE later in the process.

PR: 277269
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jlduran requested review of this revision.Nov 7 2024, 6:04 PM
jlduran created this revision.
Harbormaster completed remote builds in B60437: Diff 146143.Nov 7 2024, 6:04 PM
jlduran added a parent revision: D47475: nanobsd: Add missing options to usage().Nov 7 2024, 6:04 PM
jlduran added a comment.Nov 7 2024, 6:24 PM

I'd be tempted to remove NANO_PMAKE from embedded/common, rescue/common, and dhcpd/common.

imp accepted this revision.Nov 7 2024, 6:39 PM
This revision is now accepted and ready to land.Nov 7 2024, 6:39 PM
emaste accepted this revision.Nov 7 2024, 6:48 PM
jlduran updated this revision to Diff 146175.Nov 8 2024, 4:05 PM
  • Move the check for -DNO_CLEAN (-n), so this value is reflected when exporting the variable
This revision now requires review to proceed.Nov 8 2024, 4:05 PM
emaste accepted this revision.Nov 8 2024, 5:45 PM
This revision is now accepted and ready to land.Nov 8 2024, 5:45 PM
imp accepted this revision.Nov 8 2024, 8:21 PM
Closed by commit rG3c5d19a40de7: nanobsd: Fix parallel make (authored by jlduran). · Explain WhyNov 16 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG3c5d19a40de7: nanobsd: Fix parallel make.
jlduran added a commit: rG67dd41cdb10d: nanobsd: Fix parallel make.Dec 16 2024, 3:14 PM
jlduran added a commit: rG16fc83629869: nanobsd: Fix parallel make.

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
5 lines
4 lines

Diff 146175

View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...