Page MenuHomeFreeBSD
Differential D47476

nanobsd: Fix parallel make
ClosedPublic
Actions

Authored by jlduran on Thu, Nov 7, 6:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 2:55 PM
Unknown Object (File)
Tue, Nov 19, 2:54 PM
Unknown Object (File)
Sat, Nov 16, 6:16 PM
Unknown Object (File)
Sat, Nov 16, 7:58 AM
Unknown Object (File)
Wed, Nov 13, 9:26 AM
Unknown Object (File)
Wed, Nov 13, 5:16 AM
Unknown Object (File)
Tue, Nov 12, 8:20 AM
Unknown Object (File)
Sat, Nov 9, 4:22 AM
View All 12 Files
Subscribers
None

Details

Reviewers
imp
emaste
Commits
rG3c5d19a40de7: nanobsd: Fix parallel make
Summary

The NANO_NCPU (number of CPUs) value gets ignored by the build script
when setting the NANO_PMAKE (parallel make) value.

Fix it by setting the NANO_PMAKE later in the process.

PR: 277269
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran requested review of this revision.Thu, Nov 7, 6:04 PM
jlduran created this revision.
Harbormaster completed remote builds in B60437: Diff 146143.Thu, Nov 7, 6:04 PM
jlduran added a parent revision: D47475: nanobsd: Add missing options to usage().Thu, Nov 7, 6:04 PM
jlduran added a comment.Thu, Nov 7, 6:24 PM

I'd be tempted to remove NANO_PMAKE from embedded/common, rescue/common, and dhcpd/common.

imp accepted this revision.Thu, Nov 7, 6:39 PM
This revision is now accepted and ready to land.Thu, Nov 7, 6:39 PM
emaste accepted this revision.Thu, Nov 7, 6:48 PM
jlduran updated this revision to Diff 146175.Fri, Nov 8, 4:05 PM
  • Move the check for -DNO_CLEAN (-n), so this value is reflected when exporting the variable
This revision now requires review to proceed.Fri, Nov 8, 4:05 PM
emaste accepted this revision.Fri, Nov 8, 5:45 PM
This revision is now accepted and ready to land.Fri, Nov 8, 5:45 PM
imp accepted this revision.Fri, Nov 8, 8:21 PM
Closed by commit rG3c5d19a40de7: nanobsd: Fix parallel make (authored by jlduran). · Explain WhySat, Nov 16, 7:24 AM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG3c5d19a40de7: nanobsd: Fix parallel make.

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
5 lines
4 lines

Diff 146577

View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...