Differential D47357

cd9660: Apply the file and directory mode masks bits to all 12 access bits
ClosedPublic
Actions

Authored by jhb on Oct 31 2024, 3:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 22, 2:19 PM

	Unknown Object (File)
	Sat, Feb 22, 1:51 PM

	Unknown Object (File)
	Wed, Feb 19, 3:01 PM

	Unknown Object (File)
	Mon, Feb 3, 2:59 AM

	Unknown Object (File)
	Jan 26 2025, 5:43 AM

	Unknown Object (File)
	Jan 24 2025, 12:49 AM

	Unknown Object (File)
	Jan 24 2025, 12:21 AM

	Unknown Object (File)
	Jan 23 2025, 9:31 PM

View All 21 Files

Subscribers

Details

Reviewers

stevek
sjg
olce

Commits

rG9263f0031850: cd9660: Apply the file and directory mode masks bits to all 12 access bits
rG32b7c5e7193a: cd9660: Apply the file and directory mode masks bits to all 12 access bits
rGc1ad5b4b10c5: cd9660: Apply the file and directory mode masks bits to all 12 access bits

Summary

This permits the mask bits to control the upper 3 bits used for setuid,
setgid, and sticky permissions. While here, clarify the manpage language
as non-Rockridge volumes with extended attributes can also supply users
and groups along with permissions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60281
Build 57165: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 31 2024, 3:51 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2024, 3:51 PM

jhb requested review of this revision.Oct 31 2024, 3:51 PM

Harbormaster completed remote builds in B60281: Diff 145739.Oct 31 2024, 3:51 PM

jhb mentioned this in D46948: cd9660: Preserve non-access permission bits in file modes.Oct 31 2024, 3:52 PM

Thanks, and also for amending the doc with more technical details.

This revision is now accepted and ready to land.Oct 31 2024, 4:56 PM

sjg added inline comments.Oct 31 2024, 8:49 PM

sbin/mount_cd9660/mount_cd9660.8
91	644 is read and write for owner - no execute

jhb added inline comments.Nov 1 2024, 1:56 PM

sbin/mount_cd9660/mount_cd9660.8
91	sigh, my bad.

jhb marked an inline comment as done.Nov 1 2024, 1:57 PM

jhb added inline comments.

sbin/mount_cd9660/mount_cd9660.8
100	This should also be 555

Correct some permissions constants

This revision now requires review to proceed.Nov 1 2024, 1:58 PM

Harbormaster completed remote builds in B60328: Diff 145834.Nov 1 2024, 1:58 PM

Sigh, had missed that too. Thanks.

This revision is now accepted and ready to land.Nov 1 2024, 2:05 PM

@stevek does this version work ok for you?

Closed by commit rGc1ad5b4b10c5: cd9660: Apply the file and directory mode masks bits to all 12 access bits (authored by jhb). · Explain WhyDec 6 2024, 10:48 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc1ad5b4b10c5: cd9660: Apply the file and directory mode masks bits to all 12 access bits.

jhb added a commit: rG32b7c5e7193a: cd9660: Apply the file and directory mode masks bits to all 12 access bits.Dec 27 2024, 5:07 PM

jhb added a commit: rG9263f0031850: cd9660: Apply the file and directory mode masks bits to all 12 access bits.

Revision Contents
Changeset List

Path

Size

sbin/

mount_cd9660/

23 lines

sys/

fs/

cd9660/

cd9660_vfsops.c

2 lines

Diff 145739

sbin/mount_cd9660/mount_cd9660.8

Loading...

sys/fs/cd9660/cd9660_vfsops.c

Loading...