Page MenuHomeFreeBSD
Differential D47237

arm64: Adjust the MPASS in vfp_save_state_savectx
ClosedPublic
Actions

Authored by andrew on Oct 22 2024, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 20, 12:47 AM
Unknown Object (File)
Sat, Sep 19, 11:35 PM
Unknown Object (File)
Sat, Sep 19, 11:35 PM
Unknown Object (File)
Sat, Sep 19, 11:27 PM
Unknown Object (File)
Fri, Sep 18, 12:27 PM
Unknown Object (File)
Tue, Sep 8, 6:43 PM
Unknown Object (File)
Mon, Sep 7, 10:02 AM
Unknown Object (File)
Sun, Sep 6, 2:01 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
manu
Group Reviewers
arm64
Commits
rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx
Summary

In vfp_save_state_savectx we check if the pcb has a NULL vfp state.
When it's called multiple times with the same pcb then we can panic
because the vfp state has been set.

Weaken the requirement for the state pointer to be NULL by also
allowing it to point to the pcb vfp state area we are about to use.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60148
Build 57032: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 22 2024, 2:24 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 22 2024, 2:24 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Oct 22 2024, 2:24 PM
Harbormaster completed remote builds in B60148: Diff 145347.Oct 22 2024, 2:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2024, 5:48 PM
Closed by commit rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG9ff643a8da47: arm64: Adjust the MPASS in vfp_save_state_savectx.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
9 lines

Diff 145347

View Options

sys/arm64/arm64/vfp.c

Loading...