Page MenuHomeFreeBSD
Differential D41408

arp: Complete libxo transition.
ClosedPublic
Actions

Authored by yanhaowang on Aug 10 2023, 8:00 PM.
Tags
None
Referenced Files
F114424464: D41408.id126250.diff
Sat, Apr 12, 9:53 AM
Unknown Object (File)
Sun, Apr 6, 1:42 PM
Unknown Object (File)
Sun, Mar 30, 3:43 PM
Unknown Object (File)
Thu, Mar 20, 2:11 AM
Unknown Object (File)
Wed, Mar 19, 8:12 PM
Unknown Object (File)
Wed, Mar 19, 4:00 PM
Unknown Object (File)
Wed, Mar 19, 2:57 PM
Unknown Object (File)
Wed, Mar 19, 6:31 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
lwhsu
des
Commits
rG417842f90861: arp(8): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yanhaowang created this revision.Aug 10 2023, 8:00 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 8:00 PM
yanhaowang requested review of this revision.Aug 10 2023, 8:00 PM
Harbormaster completed remote builds in B53033: Diff 125821.Aug 10 2023, 8:00 PM
yanhaowang added reviewers: lwhsu, des.Aug 10 2023, 8:01 PM
yanhaowang updated this revision to Diff 125899.Aug 12 2023, 2:06 AM
  • Remove unnecessary space line.
Harbormaster completed remote builds in B53062: Diff 125899.Aug 12 2023, 2:06 AM
des accepted this revision.Aug 17 2023, 2:51 PM
This revision is now accepted and ready to land.Aug 17 2023, 2:51 PM
des requested changes to this revision.Aug 17 2023, 3:19 PM
des added inline comments.
usr.sbin/arp/arp.c
727

This can be changed to xo_error().

This revision now requires changes to proceed.Aug 17 2023, 3:19 PM
yanhaowang updated this revision to Diff 126247.Aug 20 2023, 3:51 AM
This comment was removed by yanhaowang.
Harbormaster completed remote builds in B53181: Diff 126247.Aug 20 2023, 3:51 AM
yanhaowang updated this revision to Diff 126249.Aug 20 2023, 4:13 AM
This comment was removed by yanhaowang.
Harbormaster completed remote builds in B53183: Diff 126249.Aug 20 2023, 4:13 AM
yanhaowang updated this revision to Diff 126250.Aug 20 2023, 4:17 AM

Using xo_error instead of fprintf.

Harbormaster completed remote builds in B53184: Diff 126250.Aug 20 2023, 4:17 AM
yanhaowang marked an inline comment as done.Aug 20 2023, 4:18 AM
des accepted this revision.Aug 26 2023, 11:46 PM
This revision is now accepted and ready to land.Aug 26 2023, 11:46 PM
Closed by commit rG417842f90861: arp(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:35 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG417842f90861: arp(8): Complete libxo transition.

Revision Contents
Changeset List

PathSize
usr.sbin/
arp/
11 lines
5 lines

Diff 144743

View Options

usr.sbin/arp/arp.c

# $FreeBSD$ # $FreeBSD$
SSP_CFLAGS= SSP_CFLAGS=
NO_WMISSING_VARIABLE_DECLARATIONS= NO_WMISSING_VARIABLE_DECLARATIONS=
.include <src.opts.mk> .include <src.opts.mk>
.if !defined(BUILDING_TESTS) .if !defined(BUILDING_TESTS)
OBJS+= Scrt1.o crt1.o gcrt1.o OBJS+= Scrt1.o crt1.o gcrt1.o
OBJS+= crtbegin.o crtbeginS.o crtbeginT.o OBJS+= crtbegin.o crtbeginS.o crtbeginT.o
OBJS+= crtend.o crtendS.o OBJS+= crtend.o crtendS.o
OBJS+= crti.o crtn.o OBJS+= crti.o crtn.o
CRT1OBJS+= crtbrand.o ignore_init_note.o CRT1OBJS+= crtbrand.o feature_note.o ignore_init_note.o
ACFLAGS+= -DLOCORE ACFLAGS+= -DLOCORE
CFLAGS+= -fno-asynchronous-unwind-tables CFLAGS+= -fno-asynchronous-unwind-tables
CFLAGS+= -fno-omit-frame-pointer CFLAGS+= -fno-omit-frame-pointer
CFLAGS+= -I${.CURDIR:H}/common \ CFLAGS+= -I${.CURDIR:H}/common \
-I${SRCTOP}/lib/libc/include -I${SRCTOP}/lib/libc/include
CFLAGS_CRTS= -DSHARED ${PICFLAG} CFLAGS_CRTS= -DSHARED ${PICFLAG}
FILES= ${OBJS} FILES= ${OBJS}
FILESMODE= ${LIBMODE} FILESMODE= ${LIBMODE}
FILESOWN= ${LIBOWN} FILESOWN= ${LIBOWN}
FILESGRP= ${LIBGRP} FILESGRP= ${LIBGRP}
FILESDIR= ${LIBDIR} FILESDIR= ${LIBDIR}
# These FILES qualify as libraries for the purpose of LIBRARIES_ONLY. # These FILES qualify as libraries for the purpose of LIBRARIES_ONLY.
.undef LIBRARIES_ONLY .undef LIBRARIES_ONLY
CLEANFILES+= ${OBJS} ${CRT1OBJS} crt1_c.o gcrt1_c.o Scrt1_c.o CLEANFILES+= ${OBJS} ${CRT1OBJS} crt1_c.o gcrt1_c.o Scrt1_c.o
CLEANFILES+= crti_s.o
crt1.o: crt1_c.o ${CRT1OBJS} crt1.o: crt1_c.o ${CRT1OBJS}
${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o} ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}
.if ${MACHINE_ARCH} == "i386" .if ${MACHINE_ARCH} == "i386"
${OBJCOPY} --localize-symbol _start1 ${.TARGET} ${OBJCOPY} --localize-symbol _start1 ${.TARGET}
.endif .endif
gcrt1_c.o: crt1_c.c gcrt1_c.o: crt1_c.c
Show All 18 Lines
crtendS.o: crtend.c crtendS.o: crtend.c
crtbegin.o crtend.o crtbeginT.o: crtbegin.o crtend.o crtbeginT.o:
${CC} ${CFLAGS} -I${.CURDIR} -c -o ${.TARGET} ${.ALLSRC:N*.h:[1]} ${CC} ${CFLAGS} -I${.CURDIR} -c -o ${.TARGET} ${.ALLSRC:N*.h:[1]}
crtbeginS.o crtendS.o: crtbeginS.o crtendS.o:
${CC} ${CFLAGS} -I${.CURDIR} ${CFLAGS_CRTS} -c -o ${.TARGET} \ ${CC} ${CFLAGS} -I${.CURDIR} ${CFLAGS_CRTS} -c -o ${.TARGET} \
${.ALLSRC:N*.h:[1]} ${.ALLSRC:N*.h:[1]}
crti_s.o: crti.S
${CC} ${CFLAGS} ${ACFLAGS} -c ${.ALLSRC:M*.S} -o ${.TARGET}
crti.o: crti_s.o crtbrand.o
jhbAuthorUnsubmitted
Done
Inline Actions

Here we link crti_s.o (generated from per-arch crti.S) and crtbrand.o to build crti.o. This is then included in both shared libraries and executables.

jhb: Here we link crti_s.o (generated from per-arch crti.S) and crtbrand.o to build crti.o. This is…
${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}
.endif .endif
.include "../Makefile.inc" .include "../Makefile.inc"
View Options

usr.sbin/arp/arp_netlink.c

# $FreeBSD$ # $FreeBSD$
SSP_CFLAGS= SSP_CFLAGS=
NO_WMISSING_VARIABLE_DECLARATIONS= NO_WMISSING_VARIABLE_DECLARATIONS=
.include <src.opts.mk> .include <src.opts.mk>
.if !defined(BUILDING_TESTS) .if !defined(BUILDING_TESTS)
OBJS+= Scrt1.o crt1.o gcrt1.o OBJS+= Scrt1.o crt1.o gcrt1.o
OBJS+= crtbegin.o crtbeginS.o crtbeginT.o OBJS+= crtbegin.o crtbeginS.o crtbeginT.o
OBJS+= crtend.o crtendS.o OBJS+= crtend.o crtendS.o
OBJS+= crti.o crtn.o OBJS+= crti.o crtn.o
CRT1OBJS+= crtbrand.o ignore_init_note.o CRT1OBJS+= crtbrand.o feature_note.o ignore_init_note.o
ACFLAGS+= -DLOCORE ACFLAGS+= -DLOCORE
CFLAGS+= -fno-asynchronous-unwind-tables CFLAGS+= -fno-asynchronous-unwind-tables
CFLAGS+= -fno-omit-frame-pointer CFLAGS+= -fno-omit-frame-pointer
CFLAGS+= -I${.CURDIR:H}/common \ CFLAGS+= -I${.CURDIR:H}/common \
-I${SRCTOP}/lib/libc/include -I${SRCTOP}/lib/libc/include
CFLAGS_CRTS= -DSHARED ${PICFLAG} CFLAGS_CRTS= -DSHARED ${PICFLAG}
FILES= ${OBJS} FILES= ${OBJS}
FILESMODE= ${LIBMODE} FILESMODE= ${LIBMODE}
FILESOWN= ${LIBOWN} FILESOWN= ${LIBOWN}
FILESGRP= ${LIBGRP} FILESGRP= ${LIBGRP}
FILESDIR= ${LIBDIR} FILESDIR= ${LIBDIR}
# These FILES qualify as libraries for the purpose of LIBRARIES_ONLY. # These FILES qualify as libraries for the purpose of LIBRARIES_ONLY.
.undef LIBRARIES_ONLY .undef LIBRARIES_ONLY
CLEANFILES+= ${OBJS} ${CRT1OBJS} crt1_c.o gcrt1_c.o Scrt1_c.o CLEANFILES+= ${OBJS} ${CRT1OBJS} crt1_c.o gcrt1_c.o Scrt1_c.o
CLEANFILES+= crti_s.o
crt1.o: crt1_c.o ${CRT1OBJS} crt1.o: crt1_c.o ${CRT1OBJS}
${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o} ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}
.if ${MACHINE_ARCH} == "i386" .if ${MACHINE_ARCH} == "i386"
${OBJCOPY} --localize-symbol _start1 ${.TARGET} ${OBJCOPY} --localize-symbol _start1 ${.TARGET}
.endif .endif
gcrt1_c.o: crt1_c.c gcrt1_c.o: crt1_c.c
Show All 18 Lines
crtendS.o: crtend.c crtendS.o: crtend.c
crtbegin.o crtend.o crtbeginT.o: crtbegin.o crtend.o crtbeginT.o:
${CC} ${CFLAGS} -I${.CURDIR} -c -o ${.TARGET} ${.ALLSRC:N*.h:[1]} ${CC} ${CFLAGS} -I${.CURDIR} -c -o ${.TARGET} ${.ALLSRC:N*.h:[1]}
crtbeginS.o crtendS.o: crtbeginS.o crtendS.o:
${CC} ${CFLAGS} -I${.CURDIR} ${CFLAGS_CRTS} -c -o ${.TARGET} \ ${CC} ${CFLAGS} -I${.CURDIR} ${CFLAGS_CRTS} -c -o ${.TARGET} \
${.ALLSRC:N*.h:[1]} ${.ALLSRC:N*.h:[1]}
crti_s.o: crti.S
${CC} ${CFLAGS} ${ACFLAGS} -c ${.ALLSRC:M*.S} -o ${.TARGET}
crti.o: crti_s.o crtbrand.o
jhbAuthorUnsubmitted
Done
Inline Actions

Here we link crti_s.o (generated from per-arch crti.S) and crtbrand.o to build crti.o. This is then included in both shared libraries and executables.

jhb: Here we link crti_s.o (generated from per-arch crti.S) and crtbrand.o to build crti.o. This is…
${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}
.endif .endif
.include "../Makefile.inc" .include "../Makefile.inc"