Page MenuHomeFreeBSD
Differential D41408

arp: Complete libxo transition.
ClosedPublic
Actions

Authored by yanhaowang on Aug 10 2023, 8:00 PM.
Tags
None
Referenced Files
F166349868: D41408.id125899.diff
Thu, Aug 13, 1:36 AM
F166323271: D41408.id126249.diff
Wed, Aug 12, 10:04 PM
F166318193: D41408.id.diff
Wed, Aug 12, 9:13 PM
F166313303: D41408.id125821.diff
Wed, Aug 12, 8:26 PM
Unknown Object (File)
Wed, Aug 12, 12:51 AM
Unknown Object (File)
Tue, Aug 11, 11:12 PM
Unknown Object (File)
Tue, Aug 11, 8:49 PM
Unknown Object (File)
Tue, Aug 11, 5:02 PM
View All Files
Subscribers
imp

Details

Reviewers
lwhsu
des
Commits
rG9d53ea06b320: arp(8): Complete libxo transition
rG417842f90861: arp(8): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53062
Build 49953: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Aug 10 2023, 8:00 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 8:00 PM
yanhaowang requested review of this revision.Aug 10 2023, 8:00 PM
Harbormaster completed remote builds in B53033: Diff 125821.Aug 10 2023, 8:00 PM
yanhaowang added reviewers: lwhsu, des.Aug 10 2023, 8:01 PM
yanhaowang updated this revision to Diff 125899.Aug 12 2023, 2:06 AM
  • Remove unnecessary space line.
Harbormaster completed remote builds in B53062: Diff 125899.Aug 12 2023, 2:06 AM
des accepted this revision.Aug 17 2023, 2:51 PM
This revision is now accepted and ready to land.Aug 17 2023, 2:51 PM
des requested changes to this revision.Aug 17 2023, 3:19 PM
des added inline comments.
usr.sbin/arp/arp.c
745

This can be changed to xo_error().

This revision now requires changes to proceed.Aug 17 2023, 3:19 PM
yanhaowang updated this revision to Diff 126247.Aug 20 2023, 3:51 AM
This comment was removed by yanhaowang.
Harbormaster completed remote builds in B53181: Diff 126247.Aug 20 2023, 3:51 AM
yanhaowang updated this revision to Diff 126249.Aug 20 2023, 4:13 AM
This comment was removed by yanhaowang.
Harbormaster completed remote builds in B53183: Diff 126249.Aug 20 2023, 4:13 AM
yanhaowang updated this revision to Diff 126250.Aug 20 2023, 4:17 AM

Using xo_error instead of fprintf.

Harbormaster completed remote builds in B53184: Diff 126250.Aug 20 2023, 4:17 AM
yanhaowang marked an inline comment as done.Aug 20 2023, 4:18 AM
des accepted this revision.Aug 26 2023, 11:46 PM
This revision is now accepted and ready to land.Aug 26 2023, 11:46 PM
Closed by commit rG417842f90861: arp(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:35 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG417842f90861: arp(8): Complete libxo transition.
eugen_grosbein.net added a commit: rG9d53ea06b320: arp(8): Complete libxo transition.Oct 16 2025, 7:15 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
arp/
17 lines
5 lines

Diff 125899

View Options

usr.sbin/arp/arp.c

Loading...
View Options

usr.sbin/arp/arp_netlink.c

Loading...