suspend on xenbus
ClosedPublic
Actions

Authored by royger on Oct 1 2024, 9:14 AM.

Details

Reviewers

ehem_freebsd_m5p.com
markj
royger

Summary

Some toolstacks won't attempt the signal power actions on xenbus unless the VM
explicitly exposes support for them. FreeBSD supports all power actions, hence
signal on xenbus such support by setting the nodes to the value of "1".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

royger created this revision.Oct 1 2024, 9:14 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 1 2024, 9:14 AM

royger requested review of this revision.Oct 1 2024, 9:14 AM

This looks ok to me aside from style nits. I don't know Xen well enough to properly review the substance of the change.

sys/dev/xen/control/control.c
401	Extra newline.
502	Extra newline.
508	Extra newline.

Thanks for the review, will get the extra newlines removed and this committed.

sys/dev/xen/control/control.c

401

Oh, we finally changed the style to not mandate an empty newline if there are no local varaibles in a function:

static void
usage(void)
{
       /* Optional blank line goes here. */

Optionally, insert a blank line at the beginning of functions with no
local variables.   Older versions of this style document required the
blank line convention, so it is widely used in existing code.

royger mentioned this in rG9dd5105f22a2: xen: expose support for poweroff/reboot/suspend on xenbus.Oct 7 2024, 5:00 PM

royger accepted this revision.Nov 5 2024, 3:33 PM

This revision is now accepted and ready to land.Nov 5 2024, 3:33 PM

royger closed this revision.Nov 5 2024, 3:33 PM