Page MenuHomeFreeBSD
Differential D46827

roundup_pow_of_two: don't take the log of it
ClosedPublic
Actions

Authored by dougm on Sep 28 2024, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 20, 6:53 AM
Unknown Object (File)
Thu, Sep 11, 3:27 AM
Unknown Object (File)
Sep 6 2025, 9:23 PM
Unknown Object (File)
Aug 29 2025, 3:16 PM
Unknown Object (File)
Jul 12 2025, 9:28 PM
Unknown Object (File)
Jul 6 2025, 9:21 AM
Unknown Object (File)
Jul 3 2025, 6:41 AM
Unknown Object (File)
Jul 1 2025, 9:38 AM
View All 40 Files
Subscribers
imp
kib

Details

Reviewers
bz
kib
Commits
rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it
Summary

Based on the definitions, ilog2(roundup_pow_of_two(x)) == order_base_2(x). Replace the former with the latter in a few places to save a few calculations.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Sep 28 2024, 12:02 AM
dougm created this revision.
bz added a reviewer: kib.Sep 28 2024, 12:11 AM
bz added a subscriber: kib.

Add @kib in the hope that he's maintaining the mlx* bits these days.

bz added a comment.Sep 28 2024, 12:11 AM

To me looks ok

kib accepted this revision.Sep 28 2024, 11:40 AM
This revision is now accepted and ready to land.Sep 28 2024, 11:40 AM
Closed by commit rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it (authored by dougm). · Explain WhySep 28 2024, 5:01 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it.
Herald added a subscriber: imp. · View Herald TranscriptSep 28 2024, 5:01 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx4/
mlx4_en/
2 lines
mlx4_ib/
4 lines

Diff 143871

View Options

sys/dev/mlx4/mlx4_en/en.h

Loading...
View Options

sys/dev/mlx4/mlx4_ib/mlx4_ib_qp.c

Loading...