Page MenuHomeFreeBSD
Differential D46777

loader: Fix 0 vs 1 confusion for column numbers
ClosedPublic
Actions

Authored by imp on Sep 24 2024, 5:16 PM.
Tags
None
Referenced Files
F168816221: D46777.id.diff
Sun, Aug 30, 7:15 AM
F168767071: D46777.diff
Sun, Aug 30, 1:24 AM
Unknown Object (File)
Fri, Aug 28, 8:13 AM
Unknown Object (File)
Wed, Aug 26, 1:23 PM
Unknown Object (File)
Wed, Aug 26, 12:12 PM
Unknown Object (File)
Wed, Aug 26, 10:52 AM
Unknown Object (File)
Sat, Aug 22, 2:02 PM
Unknown Object (File)
Thu, Aug 20, 9:03 PM
View All 97 Files
Subscribers
dab

Details

Reviewers
manu
Commits
rG28e212c74050: loader: Fix 0 vs 1 confusion for column numbers
rG65e3190d627f: loader: Fix 0 vs 1 confusion for column numbers
rG604919c47fa4: loader: Fix 0 vs 1 confusion for column numbers
Summary

In two places we use '0' for a column number. However, the upper left
hand corner of the screen is 1, 1. Fix those two confusions. Also, fix
a comment that flipped the coordinates in a comment (I'm used to the
vt100 convention where it's row, column (eg y, x)) and didn't notice
the rest of the code uses x, y.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59585
Build 56472: arc lint + arc unit

Revision Contents
Changeset List

PathSize
stand/
lua/
4 lines
2 lines

Diff 143684

View Options

stand/lua/menu.lua

Loading...
View Options

stand/lua/screen.lua

Loading...