Page MenuHomeFreeBSD
Differential D46675

dtrace/amd64: Remove the dtrace_invop_callsite symbol
ClosedPublic
Actions

Authored by markj on Sep 14 2024, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 2:27 PM
Unknown Object (File)
Feb 16 2025, 7:16 PM
Unknown Object (File)
Feb 4 2025, 8:44 AM
Unknown Object (File)
Feb 4 2025, 5:36 AM
Unknown Object (File)
Jan 28 2025, 5:08 AM
Unknown Object (File)
Jan 25 2025, 9:15 AM
Unknown Object (File)
Jan 18 2025, 1:12 AM
Unknown Object (File)
Jan 16 2025, 3:18 PM
View All 39 Files
Subscribers
imp

Details

Reviewers
gnn
avg
Group Reviewers
DTrace
Commits
rGc27106d925cd: dtrace/amd64: Remove the dtrace_invop_callsite symbol
rG06e7bc83f6a4: dtrace/amd64: Remove the dtrace_invop_callsite symbol
Summary

It is not needed after commit 7e80fd5ef397. No functional change
intended.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59488
Build 56375: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
sys/
2 lines
dev/
dtrace/
amd64/
4 lines

Diff 143344

View Options

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h

Show First 20 Lines • Show All 2,394 Lines • ▼ Show 20 Lines
extern int dtrace_safe_defer_signal(void); extern int dtrace_safe_defer_signal(void);
extern void dtrace_safe_synchronous_signal(void); extern void dtrace_safe_synchronous_signal(void);
extern int dtrace_mach_aframes(void); extern int dtrace_mach_aframes(void);
#if defined(__i386) || defined(__amd64) #if defined(__i386) || defined(__amd64)
extern int dtrace_instr_size_isa(uint8_t *, model_t, int *); extern int dtrace_instr_size_isa(uint8_t *, model_t, int *);
#ifdef __i386
extern void dtrace_invop_callsite(void); extern void dtrace_invop_callsite(void);
#endif
#endif #endif
extern void dtrace_invop_add(int (*)(uintptr_t, struct trapframe *, uintptr_t)); extern void dtrace_invop_add(int (*)(uintptr_t, struct trapframe *, uintptr_t));
extern void dtrace_invop_remove(int (*)(uintptr_t, struct trapframe *, extern void dtrace_invop_remove(int (*)(uintptr_t, struct trapframe *,
uintptr_t)); uintptr_t));
#ifdef __sparc #ifdef __sparc
extern int dtrace_blksuword32(uintptr_t, uint32_t *, int); extern int dtrace_blksuword32(uintptr_t, uint32_t *, int);
extern void dtrace_getfsr(uint64_t *); extern void dtrace_getfsr(uint64_t *);
▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines
View Options

sys/cddl/dev/dtrace/amd64/dtrace_asm.S

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines#define INTR_POP \
movq TF_R14(%rsp),%r14; \ movq TF_R14(%rsp),%r14; \
movq TF_R15(%rsp),%r15; \ movq TF_R15(%rsp),%r15; \
testb $SEL_RPL_MASK,TF_CS(%rsp); \ testb $SEL_RPL_MASK,TF_CS(%rsp); \
jz 1f; \ jz 1f; \
cli; \ cli; \
swapgs; \ swapgs; \
1: addq $TF_RIP,%rsp; 1: addq $TF_RIP,%rsp;
.globl dtrace_invop_callsite
.type dtrace_invop_callsite,@function
ENTRY(dtrace_invop_start) ENTRY(dtrace_invop_start)
/* /*
* #BP traps with %rip set to the next address. We need to decrement * #BP traps with %rip set to the next address. We need to decrement
* the value to indicate the address of the int3 (0xcc) instruction * the value to indicate the address of the int3 (0xcc) instruction
* that we substituted. * that we substituted.
*/ */
movq TF_RIP(%rsp), %rdi movq TF_RIP(%rsp), %rdi
decq %rdi decq %rdi
movq %rsp, %rsi movq %rsp, %rsi
/* /*
* Allocate some scratch space to let the invop handler return a value. * Allocate some scratch space to let the invop handler return a value.
* This is needed when emulating "call" instructions. * This is needed when emulating "call" instructions.
*/ */
subq $16, %rsp subq $16, %rsp
movq %rsp, %rdx movq %rsp, %rdx
call dtrace_invop call dtrace_invop
dtrace_invop_callsite:
addq $16, %rsp addq $16, %rsp
cmpl $DTRACE_INVOP_PUSHL_EBP, %eax cmpl $DTRACE_INVOP_PUSHL_EBP, %eax
je bp_push je bp_push
cmpl $DTRACE_INVOP_CALL, %eax cmpl $DTRACE_INVOP_CALL, %eax
je bp_call je bp_call
cmpl $DTRACE_INVOP_LEAVE, %eax cmpl $DTRACE_INVOP_LEAVE, %eax
je bp_leave je bp_leave
▲ Show 20 Lines • Show All 378 Lines • Show Last 20 Lines