Differential D46674

dtrace tests: Add a test case which validates FBT probe arguments
ClosedPublic
Actions

Authored by markj on Sep 14 2024, 6:56 PM.

Tags

None

Referenced Files

	F168799541: D46674.id143447.diff
	Sun, Aug 30, 5:31 AM

	F168799490: D46674.id143447.diff
	Sun, Aug 30, 5:31 AM

	F168766770: D46674.diff
	Sun, Aug 30, 1:23 AM

	Unknown Object (File)
	Thu, Aug 27, 7:24 PM

	Unknown Object (File)
	Thu, Aug 27, 12:02 AM

	Unknown Object (File)
	Tue, Aug 25, 4:32 AM

	Unknown Object (File)
	Tue, Aug 25, 2:20 AM

	Unknown Object (File)
	Mon, Aug 24, 11:40 PM

Subscribers

Details

Reviewers

gnn
avg

Group Reviewers

Commits

rG37a29946b91b: dtrace tests: Add a test case which validates FBT probe arguments
rGd439598dd0d3: dtrace tests: Add a test case which validates FBT probe arguments

Summary

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 14 2024, 6:56 PM

Herald added a reviewer: gnn. · View Herald TranscriptSep 14 2024, 6:56 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Sep 14 2024, 6:56 PM

Harbormaster completed remote builds in B59486: Diff 143342.Sep 14 2024, 6:56 PM

markj added a parent revision: D46673: dtrace_test: Remove the dependency on dtraceall.Sep 14 2024, 6:56 PM

markj added a child revision: D46675: dtrace/amd64: Remove the dtrace_invop_callsite symbol.

LGTM

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/fbtprovider/tst.argtest.ksh
32–33	It seems that DTrace supports args from 0 to 9 (10 of them in total). I do not see why args[9] would behave differently from args[8], but it might make sense to add it as well just for the sake of completeness.

This revision is now accepted and ready to land.Sep 15 2024, 9:09 AM

Include args[9] in the test.

This revision now requires review to proceed.Sep 15 2024, 1:32 PM

Harbormaster completed remote builds in B59496: Diff 143363.Sep 15 2024, 1:32 PM

markj marked an inline comment as done.Sep 15 2024, 1:32 PM

avg accepted this revision as: avg.Sep 15 2024, 8:10 PM

This revision is now accepted and ready to land.Sep 15 2024, 8:10 PM

Closed by commit rGd439598dd0d3: dtrace tests: Add a test case which validates FBT probe arguments (authored by markj). · Explain WhySep 19 2024, 9:54 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd439598dd0d3: dtrace tests: Add a test case which validates FBT probe arguments.

markj added a commit: rG37a29946b91b: dtrace tests: Add a test case which validates FBT probe arguments.Oct 4 2024, 3:57 PM

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

cmd/

dtrace/

test/

tst/

common/

fbtprovider/

tst.argtest.ksh

34 lines

tst.argtest.ksh.out

3 lines

usr.sbin/

dtrace/

tests/

common/

fbtprovider/

2 lines

sys/

cddl/

dev/

dtrace/

28 lines

Diff 143447

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/fbtprovider/tst.argtest.ksh

Loading...

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/fbtprovider/tst.argtest.ksh.out

Loading...

cddl/usr.sbin/dtrace/tests/common/fbtprovider/Makefile

Loading...

sys/cddl/dev/dtrace/dtrace_test.c

Loading...