Page MenuHomeFreeBSD
Differential D46564

bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd()
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Sep 6 2024, 1:21 PM.
Tags
None
Referenced Files
F102245494: D46564.diff
Sat, Nov 9, 12:08 PM
Unknown Object (File)
Wed, Nov 6, 8:28 AM
Unknown Object (File)
Tue, Oct 22, 8:56 PM
Unknown Object (File)
Tue, Oct 22, 12:01 PM
Unknown Object (File)
Oct 5 2024, 3:47 AM
Unknown Object (File)
Sep 26 2024, 5:45 PM
Unknown Object (File)
Sep 23 2024, 6:05 PM
Unknown Object (File)
Sep 23 2024, 11:26 AM
View All 29 Files
Subscribers
bcran
corvink
imp
rgrimes

Details

Reviewers
corvink
Group Reviewers
bhyve
Commits
rGbc3d09e90b86: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59401
Build 56288: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Sep 6 2024, 1:21 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptSep 6 2024, 1:21 PM
rosenfeld_grumpf.hope-2000.org requested review of this revision.Sep 6 2024, 1:21 PM
Harbormaster completed remote builds in B59341: Diff 143026.Sep 6 2024, 1:21 PM
rosenfeld_grumpf.hope-2000.org added a child revision: D46373: bhyve: TPM 2.0 emulation with swtpm.Sep 6 2024, 1:25 PM
rosenfeld_grumpf.hope-2000.org added a parent revision: D46562: bhyve: don't crash when guest writes TPM int_enable register.
corvink accepted this revision.Sep 9 2024, 6:13 AM
corvink added a subscriber: corvink.

Please add a commit message.

usr.sbin/bhyve/tpm_intf_crb.c
188

unnecessary whitespace change

This revision is now accepted and ready to land.Sep 9 2024, 6:13 AM
rosenfeld_grumpf.hope-2000.org updated this revision to Diff 143137.Sep 9 2024, 12:51 PM

Add more elaborate commit message. Remove the extra empty line.

This revision now requires review to proceed.Sep 9 2024, 12:51 PM
Harbormaster completed remote builds in B59401: Diff 143137.Sep 9 2024, 12:51 PM
corvink accepted this revision.Sep 18 2024, 12:43 PM

Where's the commit message?

This revision is now accepted and ready to land.Sep 18 2024, 12:43 PM
rosenfeld_grumpf.hope-2000.org added a comment.Sep 19 2024, 10:36 AM
In D46564#1064476, @corvink wrote:

Where's the commit message?

In the commit, where it belongs. :)

(Revision Contents -> Commits here in the Phabricator web GUI)

Closed by commit rGbc3d09e90b86: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd() (authored by rosenfeld_grumpf.hope-2000.org, committed by corvink). · Explain WhyTue, Oct 22, 12:07 PM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rGbc3d09e90b86: bhyve: TPM CRB: pass actual TPM request length to backend execute_cmd().

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
44 lines

Diff 143137

View Options

usr.sbin/bhyve/tpm_intf_crb.c

Loading...