Page MenuHomeFreeBSD

vmm: Use make_dev_s() to create vmm devices
ClosedPublic

Authored by markj on Aug 30 2024, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 7:35 AM
Unknown Object (File)
Tue, Nov 4, 8:07 AM
Unknown Object (File)
Mon, Nov 3, 6:08 PM
Unknown Object (File)
Mon, Oct 27, 6:20 PM
Unknown Object (File)
Mon, Oct 27, 4:50 PM
Unknown Object (File)
Mon, Oct 27, 10:01 AM
Unknown Object (File)
Mon, Oct 27, 9:52 AM
Unknown Object (File)
Tue, Oct 21, 3:38 AM
Subscribers

Details

Summary

This avoids creating windows where a device file is accessible but the
device-specific field is not set.

Now that vmmdev_mtx is a sleepable lock, avoid dropping it while
creating devices files. This makes it easier to handle races and
simplifies some code; for example, the VSC_LINKED flag is no longer
needed.

Suggested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59245
Build 56132: arc lint + arc unit

Event Timeline

jhb added a subscriber: jhb.

Hmm, so nothing was checking for si_drv1 being NULL in the cdevsw methods? Oof.

This revision is now accepted and ready to land.Aug 30 2024, 3:41 PM

Yikes indeed! Nice catch. It likely was usually fine, but yikes!

This revision was automatically updated to reflect the committed changes.