Page MenuHomeFreeBSD
Differential D46309

sound: Improve sndstat nvlist feederchain format
ClosedPublic
Actions

Authored by christos on Aug 15 2024, 4:12 PM.
Tags
None
Referenced Files
F101850275: D46309.diff
Mon, Nov 4, 4:29 PM
Unknown Object (File)
Fri, Nov 1, 5:01 PM
Unknown Object (File)
Wed, Oct 23, 8:31 PM
Unknown Object (File)
Sun, Oct 20, 10:52 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:50 PM
View All 25 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG8156d8598f59: sound: Improve sndstat nvlist feederchain format
rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format
Summary
  • Use snd_afmt2str() to display format conversions in feeder_format, instead of the plain hex value.
  • Simplify feeder_rate contents.
  • Print "ch" (e.g 2.1ch) after matrix values in feeder_matrix.
  • Use snd_afmt2str() instead of a plain hex for the the rest of the feeder classes.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59109
Build 55996: arc lint + arc unit

Event Timeline

christos created this revision.Aug 15 2024, 4:12 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 15 2024, 4:12 PM
christos requested review of this revision.Aug 15 2024, 4:12 PM
Harbormaster completed remote builds in B59038: Diff 142119.Aug 15 2024, 4:12 PM
christos added inline comments.Aug 15 2024, 4:13 PM
sys/dev/sound/pcm/sndstat.c
555

I think we could omit the hex here.

dev_submerge.ch added inline comments.Aug 20 2024, 3:13 PM
sys/dev/sound/pcm/sndstat.c
555

I suppose we can use snd_afmt2str() as in feeder_format, otherwise it looks a bit strange in the feeder chain.

christos edited the summary of this revision. (Show Details)Aug 20 2024, 3:23 PM
christos updated this revision to Diff 142267.Aug 20 2024, 3:24 PM
christos marked an inline comment as done.

Use snd_aftm2str() instead of plain hex value for the rest of the feeder
classes.

Harbormaster completed remote builds in B59109: Diff 142267.Aug 20 2024, 3:24 PM
christos added a comment.Aug 23 2024, 2:03 PM

Bump.

dev_submerge.ch accepted this revision.Aug 23 2024, 8:53 PM
This revision is now accepted and ready to land.Aug 23 2024, 8:53 PM
Closed by commit rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format (authored by christos). · Explain WhyAug 24 2024, 12:09 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format.
christos added a commit: rG8156d8598f59: sound: Improve sndstat nvlist feederchain format.Aug 26 2024, 1:55 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
18 lines

Diff 142267

View Options

sys/dev/sound/pcm/sndstat.c

Loading...