Page MenuHomeFreeBSD

sound: Improve sndstat nvlist feederchain format
ClosedPublic

Authored by christos on Aug 15 2024, 4:12 PM.
Tags
None
Referenced Files
F101850275: D46309.diff
Mon, Nov 4, 4:29 PM
Unknown Object (File)
Fri, Nov 1, 5:01 PM
Unknown Object (File)
Wed, Oct 23, 8:31 PM
Unknown Object (File)
Sun, Oct 20, 10:52 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:51 PM
Unknown Object (File)
Sun, Oct 20, 10:50 PM
Subscribers

Details

Summary
  • Use snd_afmt2str() to display format conversions in feeder_format, instead of the plain hex value.
  • Simplify feeder_rate contents.
  • Print "ch" (e.g 2.1ch) after matrix values in feeder_matrix.
  • Use snd_afmt2str() instead of a plain hex for the the rest of the feeder classes.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/sndstat.c
555

I think we could omit the hex here.

sys/dev/sound/pcm/sndstat.c
555

I suppose we can use snd_afmt2str() as in feeder_format, otherwise it looks a bit strange in the feeder chain.

christos marked an inline comment as done.

Use snd_aftm2str() instead of plain hex value for the rest of the feeder
classes.

This revision is now accepted and ready to land.Aug 23 2024, 8:53 PM