Paths

Table of Contentst

Differential D46309

sound: Improve sndstat nvlist feederchain format
ClosedPublic
Actions

Authored by christos on Aug 15 2024, 4:12 PM.

Tags

None

Referenced Files

	F167180163: D46309.id142267.diff
	Wed, Aug 19, 4:57 PM

	F167171879: D46309.id142404.diff
	Wed, Aug 19, 3:55 PM

	F167152575: D46309.id142119.diff
	Wed, Aug 19, 12:57 PM

	Unknown Object (File)
	Tue, Aug 18, 8:35 PM

	Unknown Object (File)
	Tue, Aug 18, 8:10 PM

	Unknown Object (File)
	Tue, Aug 18, 8:05 PM

	Unknown Object (File)
	Sun, Aug 16, 9:29 PM

	Unknown Object (File)
	Tue, Aug 11, 12:55 PM

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG8156d8598f59: sound: Improve sndstat nvlist feederchain format
rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format

Summary

Use snd_afmt2str() to display format conversions in feeder_format, instead of the plain hex value.
Simplify feeder_rate contents.
Print "ch" (e.g 2.1ch) after matrix values in feeder_matrix.
Use snd_afmt2str() instead of a plain hex for the the rest of the feeder classes.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59038
Build 55925: arc lint + arc unit

Event Timeline

christos created this revision.Aug 15 2024, 4:12 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2024, 4:12 PM

christos requested review of this revision.Aug 15 2024, 4:12 PM

Harbormaster completed remote builds in B59038: Diff 142119.Aug 15 2024, 4:12 PM

christos added inline comments.Aug 15 2024, 4:13 PM

sys/dev/sound/pcm/sndstat.c
552	I think we could omit the hex here.

dev_submerge.ch added inline comments.Aug 20 2024, 3:13 PM

sys/dev/sound/pcm/sndstat.c
552	I suppose we can use `snd_afmt2str()` as in feeder_format, otherwise it looks a bit strange in the feeder chain.

christos edited the summary of this revision. (Show Details)Aug 20 2024, 3:23 PM

Use snd_aftm2str() instead of plain hex value for the rest of the feeder
classes.

Harbormaster completed remote builds in B59109: Diff 142267.Aug 20 2024, 3:24 PM

Bump.

dev_submerge.ch accepted this revision.Aug 23 2024, 8:53 PM

This revision is now accepted and ready to land.Aug 23 2024, 8:53 PM

Closed by commit rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format (authored by christos). · Explain WhyAug 24 2024, 12:09 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG0864dfe6299b: sound: Improve sndstat nvlist feederchain format.

christos added a commit: rG8156d8598f59: sound: Improve sndstat nvlist feederchain format.Aug 26 2024, 1:55 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

20 lines

Diff 142119

sys/dev/sound/pcm/sndstat.c

Loading...