Page MenuHomeFreeBSD
Differential D46162

sound: Fix sndstat's devnode field
AbandonedPublic
Actions

Authored by christos on Jul 26 2024, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 6, 8:46 AM
Unknown Object (File)
Tue, Jul 1, 8:23 AM
Unknown Object (File)
Mon, Jun 23, 10:28 PM
Unknown Object (File)
Thu, Jun 19, 7:49 AM
Unknown Object (File)
Tue, Jun 17, 12:23 AM
Unknown Object (File)
Sun, Jun 15, 11:09 PM
Unknown Object (File)
Mon, Jun 9, 1:48 PM
Unknown Object (File)
May 13 2025, 7:49 AM
View All 29 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

Not including "/dev/" in the devnode string makes it hard for consumer
to use this field.

Sponsored by: The FreeBSD Foundation
MFC after 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58858
Build 55745: arc lint + arc unit

Event Timeline

christos created this revision.Jul 26 2024, 1:28 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2024, 1:28 PM
christos requested review of this revision.Jul 26 2024, 1:28 PM
Harbormaster completed remote builds in B58858: Diff 141440.Jul 26 2024, 1:28 PM
markj added a comment.Jul 26 2024, 1:33 PM

I don't really see why this change is useful, and it looks like it could break scripts etc. that scrape sndstat.

christos added a comment.Jul 26 2024, 1:42 PM
In D46162#1052007, @markj wrote:

I don't really see why this change is useful, and it looks like it could break scripts etc. that scrape sndstat.

I find it easier to use it to test paths this way, otherwise the application will have to slice the input string in order to match this format. However, I do not really mind to abandon this patch if you think it'd be more of a problem than help.

christos abandoned this revision.Jul 26 2024, 2:45 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines

Diff 141440

View Options

sys/dev/sound/pcm/sndstat.c

Loading...