sound: Fix sndstat's devnode field
AbandonedPublic
Actions

Authored by christos on Jul 26 2024, 1:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 6, 5:10 PM

	Unknown Object (File)
	Mon, Sep 2, 1:48 AM

	Unknown Object (File)
	Sun, Sep 1, 11:04 PM

	Unknown Object (File)
	Wed, Aug 21, 7:26 PM

	Unknown Object (File)
	Wed, Aug 21, 12:20 AM

	Unknown Object (File)
	Mon, Aug 19, 3:05 PM

	Unknown Object (File)
	Mon, Aug 19, 3:04 PM

	Unknown Object (File)
	Jul 29 2024, 12:19 AM

View All 9 Files

Subscribers

imp

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Not including "/dev/" in the devnode string makes it hard for consumer
to use this field.

Sponsored by: The FreeBSD Foundation
MFC after 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58858
Build 55745: arc lint + arc unit

Event Timeline

christos created this revision.Jul 26 2024, 1:28 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2024, 1:28 PM

christos requested review of this revision.Jul 26 2024, 1:28 PM

Harbormaster completed remote builds in B58858: Diff 141440.Jul 26 2024, 1:28 PM

I don't really see why this change is useful, and it looks like it could break scripts etc. that scrape sndstat.

In D46162#1052007, @markj wrote:

I don't really see why this change is useful, and it looks like it could break scripts etc. that scrape sndstat.

I find it easier to use it to test paths this way, otherwise the application will have to slice the input string in order to match this format. However, I do not really mind to abandon this patch if you think it'd be more of a problem than help.

christos abandoned this revision.Jul 26 2024, 2:45 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sndstat.c

2 lines

Diff 141440

View Options

sys/dev/sound/pcm/sndstat.c

sound: Fix sndstat's devnode fieldAbandonedPublicActions