Page MenuHomeFreeBSD

sysrc: Be quiet when changing values
AcceptedPublic

Authored by jlduran on Jul 24 2024, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 9, 3:20 PM
Unknown Object (File)
Fri, Oct 2, 5:07 AM
Unknown Object (File)
Thu, Oct 1, 6:01 PM
Unknown Object (File)
Thu, Oct 1, 4:39 PM
Unknown Object (File)
Thu, Oct 1, 2:10 AM
Unknown Object (File)
Wed, Sep 30, 4:21 AM
Unknown Object (File)
Mon, Sep 14, 10:49 PM
Unknown Object (File)
Sat, Sep 12, 1:54 AM

Details

Reviewers
dteske
imp
Summary

Currently the behavior is the same with or without the quiet (-q) flag:

Before:

# sysrc -q hostname=foo
hostname:  -> foo

After:

# sysrc -q hostname=foo
Test Plan

Not much fuzz about this change, just to avoid redirecting the output.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Some bogus file creeped in. I apologize.

This revision is now accepted and ready to land.Jul 25 2024, 2:30 AM

I see a resemblance with sysctl here, and I would not want to change that.

If sysctl also had a "really be quiet" option (let's say -Q or -qq), then sysrc should mimic that.

Thoughts?

EDIT: (cross-reference: there is no shame in redirecting)

Thanks for raising this, I'll make it a priority to review this soon

Looks good. Unless you object, I'll commit it on your behalf

Looks good. Unless you object, I'll commit it on your behalf

Thank you! Yes, I would prefer that you commit on my behalf.
I do not object, at the time I was trying to make it easier for the rc group to facilitate having an option to fully boot muted (à la OmniOS) without resorting to /dev/null redirections.