Indentation (and below)

This is bogus, we should be checking which SoC we are on & mapping based on that.

Missing unmap for prcm handle

Missing unmap for prcm handle

You can use cp15_l2ctlr_get here, from machine/cpu-v6.h.

Use CPUV7_L2CTLR_NPROC from machine/armreg.h

How similar are the two functions? i.e. could the common bits be pulled out to a helper function?

Split lines should be indented the same number of tabs, followed by 4 spaces.

8?

We need to write 0xff, 0x7f, 0x3f etc ...
I guess I could add a CPU_POWER_CLAMP_STEPS define.

I think this code could be reworked a little to add separate functions for the two groups of SoCs. These would just map/unmap the registers, then call into common functions to power on the new CPUs. They should pass in the needed tag and handles, and maybe registers if applicable.

This would help for when we move to start CPUs through the PLATFORM code.

The indentation here was correct

This should be tabbed out to the same level as the previous line, followed by 4 spaces. You should then be able to fit both on a single line.

It looks like you don't need to split this line, it should be should enough.

These should be on a single line

Do we know the meaning of 3?

Yeah, last diff add defines for this value.

} else { on a single line

} else { on a single line

4 spaces instead of a tab for multi-line if

4 spaces instead of a tab for multi-line if

4 spaces instead of a tab for multi-line if