irc/scrollz: Summary
- Update PORTVERSION and distinfo checksum (2.3)
- Take MAINTAINERSHIP
- Change configure options to port options (Barnerd)
- Update pkg-list (Barnerd)
- Remove REGEX_DESC and add it to bsd.options.desc.mk
- Use github for disfiles
Differential D5527
irc/scrollz: Update to 2.3 chris_bsdjunk.com on Mar 3 2016, 5:51 AM. Authored by Tags None Referenced Files
Subscribers None
Details
irc/scrollz: Summary
Diff Detail
Event Timeline
Comment Actions Also when you upload a diff manually (as opposed to using arcanist), you should add more context so that the reviewer can have more context too. With svn or git: svn diff -x -U9999 git diff -U9999 Comment Actions scrollz-2.3 depends on file: /usr/local/sbin/pkg - found After doing the above. "it works but looks ugly" is this how github names files or am I missing something ? This comment was removed by chris_bsdjunk.com. This comment was removed by chris_bsdjunk.com. This comment was removed by chris_bsdjunk.com. Comment Actions Yes, it is how it is supposed to be, do not change the DISTNAME of a USE_GITHUB port. That way, it is guaranteed to be unique. Thank you. When you do that, the reviewer get nice "show more lines" stuff, and we can have a look around to see if we find something strange, or bad, or useless, or... ?
Comment Actions comments
Comment Actions Update with options from Barnerd and pkg-plist update. however I am unsure why it fails now If anyone can shed some light as the only difference is a few additions. But it will no longer build. Comment Actions What does make -V DATADIR says ? I guess it's installing in share/scrollz and DATADIR contains share/ScrollZ. Comment Actions % make -VDATADIR however that shouldn't matter as %%DATADIR%% =PREFIX/share/PORTNAME. Comment Actions Yes. I'll repeat. It's installing in share/scrollz (all lowercase) and datadir is share/ScrollZ (with caps) Comment Actions I fixed it by re adding the older bits: PORTNAME= ${GH_ACCOUNT:tl} USE_GITHUB= yes But I believe that shouldn't matter but in reality it does. http://pkgs.bsdjunk.com/data/10amd64-cpet/2016-03-03_17h02m52s/logs/scrollz-2.3.log Comment Actions No. The correct fix is either to set DATADIR=${PREFIX}/share/scrollz, or to pass DATADIR to the port so that it installs in the right place. Comment Actions Sorry I understand now, I change it to: Comment Actions I need to mention that the Options things and the pkg-desc edit was originally taken from Barnerd's review.
Comment Actions no problem, I'm the one stupid enough to have asked phabricator to subscribe me to every ports review, might as well do something with it :-)
Comment Actions No, they will just not inherit the description from bsd.options.desc.mk, since its defined in the port itself. Since a shared REGEX_DESC has been created, it's probably worth removing REGEX_DESC from those ports where the description exactly matches the shared one: /usr/ports/www/libevhtp/Makefile:REGEX_DESC= Enable regex support The other matches have more specific descriptions, which may mean the shared description is not suitable or specific enough: /usr/ports/mail/perdition/Makefile:POSIX_REGEX_DESC= Native regex support
|