Paths

Table of Contentst

Differential D45929

vt: Add vd_bitblt_argb
ClosedPublic
Actions

Authored by manu on Jul 9 2024, 12:43 PM.

Tags

None

Referenced Files

	F102919948: D45929.id140716.diff
	Mon, Nov 18, 6:14 PM

	Unknown Object (File)
	Fri, Nov 15, 2:35 AM

	Unknown Object (File)
	Sun, Nov 10, 6:49 PM

	Unknown Object (File)
	Sat, Nov 9, 6:47 PM

	Unknown Object (File)
	Fri, Nov 8, 1:37 PM

	Unknown Object (File)
	Fri, Nov 8, 5:23 AM

	Unknown Object (File)
	Thu, Nov 7, 5:08 PM

	Unknown Object (File)
	Wed, Nov 6, 8:41 PM

Subscribers

Details

Reviewers

dumbbell
tsoome

Group Reviewers

Commits

rG01215ffec65a: vt: Add vd_bitblt_argb
rGb93028d8cd3a: vt: Add vd_bitblt_argb

Summary

This blit an ARGB image on the dedicated vd.
This also adds vt_fb_bitblt_argb which will works for most of the vt backends

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58579
Build 55467: arc lint + arc unit

Event Timeline

manu created this revision.Jul 9 2024, 12:43 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 9 2024, 12:43 PM

manu requested review of this revision.Jul 9 2024, 12:43 PM

Harbormaster completed remote builds in B58579: Diff 140716.Jul 9 2024, 12:43 PM

manu added a child revision: D45930: linker: Add MODINFOMD_SPLASH type.Jul 9 2024, 12:45 PM

manu added reviewers: Loader, dumbbell.

tsoome accepted this revision.Jul 9 2024, 1:01 PM

This revision is now accepted and ready to land.Jul 9 2024, 1:01 PM

Should we add vd_bitblt_argb implementations to simplefb and virtio-gpu?

In D45929#1047114, @andrew wrote:

Should we add vd_bitblt_argb implementations to simplefb and virtio-gpu?

For simplefb the current form will only work with the a8r8g8b8 and x8r8g8b8 form so we need some kind of validation first.
I was planning to do that after (I need to dig up some arm64 boards and update them before working on this).
Where is the virtio-gpu stuff ?

In D45929#1047205, @manu wrote:

In D45929#1047114, @andrew wrote:

Should we add vd_bitblt_argb implementations to simplefb and virtio-gpu?

For simplefb the current form will only work with the a8r8g8b8 and x8r8g8b8 form so we need some kind of validation first.
I was planning to do that after (I need to dig up some arm64 boards and update them before working on this).
Where is the virtio-gpu stuff ?

But I should probably do a stub which returns EOPNOTSUPP for now otherwise we will panic

Add stub for simplefb

This revision now requires review to proceed.Jul 10 2024, 5:39 AM

Harbormaster completed remote builds in B58599: Diff 140748.Jul 10 2024, 5:39 AM

tsoome accepted this revision.Jul 10 2024, 5:51 AM

This revision is now accepted and ready to land.Jul 10 2024, 5:51 AM

In D45929#1047205, @manu wrote:

Where is the virtio-gpu stuff ?

sys/dev/virtio/gpu

Add a stub for virtio_gpu

This revision now requires review to proceed.Jul 10 2024, 9:51 AM

Harbormaster completed remote builds in B58600: Diff 140751.Jul 10 2024, 9:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2024, 6:51 AM

Closed by commit rGb93028d8cd3a: vt: Add vd_bitblt_argb (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGb93028d8cd3a: vt: Add vd_bitblt_argb.

manu added a commit: rG01215ffec65a: vt: Add vd_bitblt_argb.Jul 29 2024, 4:38 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

vt/

hw/

efifb/

1 line

fb/

1 line

1 line

47 lines

ofwfb/

12 lines

vbefb/

1 line

vga/

12 lines

5 lines

Diff 140716

sys/dev/vt/hw/efifb/efifb.c

Loading...

sys/dev/vt/hw/fb/vt_early_fb.c

Loading...

sys/dev/vt/hw/fb/vt_fb.h

Loading...

sys/dev/vt/hw/fb/vt_fb.c

Loading...

sys/dev/vt/hw/ofwfb/ofwfb.c

Loading...

sys/dev/vt/hw/vbefb/vbefb.c

Loading...

sys/dev/vt/hw/vga/vt_vga.c

Loading...

sys/dev/vt/vt.h

Loading...