socket: Make soref() assert that so_count > 0
Needs ReviewPublic
Actions

Authored by markj on Jul 8 2024, 4:25 PM.

Tags

None

Referenced Files

	F153981542: D45921.id140699.diff
	Sat, Apr 25, 6:08 AM

	F153979934: D45921.id141740.diff
	Sat, Apr 25, 5:55 AM

	Unknown Object (File)
	Fri, Apr 24, 6:13 AM

	Unknown Object (File)
	Sun, Apr 19, 4:33 PM

	Unknown Object (File)
	Sat, Apr 18, 8:07 PM

	Unknown Object (File)
	Thu, Apr 16, 6:53 PM

	Unknown Object (File)
	Mon, Apr 13, 7:59 PM

	Unknown Object (File)
	Mon, Apr 13, 5:16 AM

View All 100 Files

Subscribers

imp

olce

Details

Reviewers

glebius

Summary

This might help catch some bugs. socreate() currently violates this
assertion, so initialize its refcount manually (and without an atomic
instruction) before attaching to the protocol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58570
Build 55458: arc lint + arc unit

Event Timeline

markj created this revision.Jul 8 2024, 4:25 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 8 2024, 4:25 PM

markj requested review of this revision.Jul 8 2024, 4:25 PM

Harbormaster completed remote builds in B58570: Diff 140699.Jul 8 2024, 4:25 PM

glebius accepted this revision.Jul 9 2024, 7:48 PM

This revision is now accepted and ready to land.Jul 9 2024, 7:48 PM

Avoid calling sofree() when pr_attach failed.

This revision now requires review to proceed.Aug 2 2024, 1:58 PM

Harbormaster completed remote builds in B58920: Diff 141740.Aug 2 2024, 1:58 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_socket.c

4 lines

sys/

socketvar.h

6 lines

Diff 140699

View Options

sys/kern/uipc_socket.c