Page MenuHomeFreeBSD
Differential D45890

stand: Add "Loader needs updating" to the first menu item"
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 8:48 PM.
Tags
None
Referenced Files
F167015856: D45890.id141555.diff
Tue, Aug 18, 2:44 PM
Unknown Object (File)
Sat, Aug 8, 5:20 PM
Unknown Object (File)
Sat, Aug 8, 11:39 AM
Unknown Object (File)
Fri, Aug 7, 9:59 PM
Unknown Object (File)
Thu, Aug 6, 10:11 AM
Unknown Object (File)
Thu, Aug 6, 6:30 AM
Unknown Object (File)
Wed, Aug 5, 1:45 PM
Unknown Object (File)
Wed, Aug 5, 5:07 AM
View All Files
Subscribers
dab

Details

Reviewers
kevans
manu
jhb
Commits
rG934691dbf34d: stand: Add "Loader needs updating" to the first menu item"
rG59bfc69490ea: stand: Add "Loader needs updating" to the first menu item"
rG0eac99f76ec3: stand: Add "Loader needs updating" to the first menu item"
Summary

When the boot loader version is too old, add a warning to the boot menu
to maybe catch people's attention.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58528
Build 55416: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 8:48 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 8:48 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jul 5 2024, 8:48 PM
Harbormaster completed remote builds in B58528: Diff 140601.Jul 5 2024, 8:48 PM
imp added a parent revision: D45889: stand: Print a warning of the loader is too old.Jul 5 2024, 8:48 PM
jhb accepted this revision.Jul 9 2024, 2:02 PM
This revision is now accepted and ready to land.Jul 9 2024, 2:02 PM
kevans added inline comments.Jul 9 2024, 8:47 PM
stand/lua/menu.lua
419
421

We probably have others that should be converted, but I'd just replace these three lines with visible = core.loaderTooOld

Closed by commit rG0eac99f76ec3: stand: Add "Loader needs updating" to the first menu item" (authored by imp). · Explain WhyJul 29 2024, 10:58 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG0eac99f76ec3: stand: Add "Loader needs updating" to the first menu item".
imp added a commit: rG59bfc69490ea: stand: Add "Loader needs updating" to the first menu item".Aug 1 2024, 2:52 PM
imp added a commit: rG934691dbf34d: stand: Add "Loader needs updating" to the first menu item".Aug 1 2024, 2:57 PM

Revision Contents
Changeset List

PathSize
stand/
lua/
10 lines

Diff 140601

View Options

stand/lua/menu.lua

Loading...