Page MenuHomeFreeBSD
Differential D45881

Revert "loader/lua: Remove pager shim"
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 4, 9:09 PM
Unknown Object (File)
Fri, May 30, 9:12 PM
Unknown Object (File)
Sun, May 25, 11:16 AM
Unknown Object (File)
Sat, May 24, 3:36 AM
Unknown Object (File)
Fri, May 16, 10:19 AM
Unknown Object (File)
Apr 23 2025, 8:42 PM
Unknown Object (File)
Apr 22 2025, 9:26 AM
Unknown Object (File)
Apr 22 2025, 3:58 AM
View All 55 Files
Subscribers
andrew_tao173.riddles.org.uk
dab

Details

Reviewers
kevans
manu
Commits
rG90ca43b5dcf0: Revert "loader/lua: Remove pager shim"
rGb38a82c77ab9: Revert "loader/lua: Remove pager shim"
Summary

This reverts commit 8b9178cd0d35ff2beafebdd51c8c44ba2b5aeb0f.

Really old loader.efi files persist in the field. Revert this to support
it, but add a complaint that the boot loader is too old. We need to
support this through at least 14.2 now, alas.

MFC After: 3 days
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58523
Build 55411: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 6:23 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 6:23 PM
Herald added subscribers: dab, andrew_tao173.riddles.org.uk. · View Herald Transcript
imp requested review of this revision.Jul 5 2024, 6:23 PM
imp added a parent revision: D45880: stand: Kill commented out line.
Harbormaster completed remote builds in B58515: Diff 140584.Jul 5 2024, 6:23 PM
imp added a child revision: D45882: Revert "loader/lua: Remove compat shim for loader.lua_path".Jul 5 2024, 6:23 PM
imp updated this revision to Diff 140596.Jul 5 2024, 8:47 PM

Just revert, kill the other changes.
Commit message locally updated to remove bit about whining, that will be a separate,
future commit.

Harbormaster completed remote builds in B58523: Diff 140596.Jul 5 2024, 8:47 PM
kevans accepted this revision.Jul 9 2024, 8:40 PM
This revision is now accepted and ready to land.Jul 9 2024, 8:40 PM
Closed by commit rGb38a82c77ab9: Revert "loader/lua: Remove pager shim" (authored by imp). · Explain WhyJul 29 2024, 10:57 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb38a82c77ab9: Revert "loader/lua: Remove pager shim".
imp added a commit: rG90ca43b5dcf0: Revert "loader/lua: Remove pager shim".Aug 1 2024, 2:51 PM

Revision Contents
Changeset List

PathSize
stand/
lua/
12 lines

Diff 140596

View Options

stand/lua/cli.lua

Loading...