Page MenuHomeFreeBSD
Differential D45857

sound: Handle midistat_lock through function interface
ClosedPublic
Actions

Authored by christos on Jul 3 2024, 2:14 PM.
Tags
None
Referenced Files
F151130615: D45857.id140507.diff
Mon, Apr 6, 7:14 AM
Unknown Object (File)
Sun, Apr 5, 5:58 PM
Unknown Object (File)
Sun, Apr 5, 8:19 AM
Unknown Object (File)
Sat, Apr 4, 5:14 AM
Unknown Object (File)
Fri, Apr 3, 3:29 AM
Unknown Object (File)
Wed, Mar 25, 11:43 PM
Unknown Object (File)
Wed, Mar 25, 11:40 PM
Unknown Object (File)
Mar 7 2026, 5:18 PM
View All 87 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGff6b61a2c886: sound: Handle midistat_lock through function interface
rG2d6fc24673cc: sound: Handle midistat_lock through function interface
Summary

midistat_lock is used outside midi/midi.c as well, so implement lock,
unlock and lockassert functions in order to not expose the lock in the
header file.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58474
Build 55362: arc lint + arc unit

Event Timeline

christos created this revision.Jul 3 2024, 2:14 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2024, 2:14 PM
christos requested review of this revision.Jul 3 2024, 2:14 PM
christos added a parent revision: D45770: sound: Fix lock order reversals in mseq_open().Jul 3 2024, 2:14 PM
christos mentioned this in D45770: sound: Fix lock order reversals in mseq_open().
Harbormaster completed remote builds in B58474: Diff 140507.Jul 3 2024, 2:15 PM
christos updated this revision to Diff 140508.Jul 3 2024, 2:16 PM

Move function declarations at the top to match the function definitions'
position.

Harbormaster completed remote builds in B58475: Diff 140508.Jul 3 2024, 2:16 PM
emaste added inline comments.Jul 6 2024, 3:43 PM
sys/dev/sound/midi/midi.c
180

I assume the rename here is to make sure there are no leftover (or external) consumers?

christos added inline comments.Jul 6 2024, 3:49 PM
sys/dev/sound/midi/midi.c
180

It's because midistat_lock() will have the same name as the lock and we'll get a compile error.

emaste accepted this revision.Jul 6 2024, 4:43 PM
This revision is now accepted and ready to land.Jul 6 2024, 4:43 PM
Closed by commit rG2d6fc24673cc: sound: Handle midistat_lock through function interface (authored by christos). · Explain WhyJul 6 2024, 6:24 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG2d6fc24673cc: sound: Handle midistat_lock through function interface.
christos added a commit: rGff6b61a2c886: sound: Handle midistat_lock through function interface.Jul 10 2024, 4:49 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
midi/
6 lines
76 lines
4 lines

Diff 140507

View Options

sys/dev/sound/midi/midi.h

Loading...
View Options

sys/dev/sound/midi/midi.c

Loading...
View Options

sys/dev/sound/midi/sequencer.c

Loading...