Page MenuHomeFreeBSD
Differential D45577

amd64 pmap: Release PTP reference on leaf ptpage allocation failure
ClosedPublic
Actions

Authored by bnovkov on Jun 13 2024, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 19, 6:04 PM
Unknown Object (File)
Sat, Jul 11, 4:19 PM
Unknown Object (File)
Mon, Jul 6, 10:45 PM
Unknown Object (File)
Fri, Jun 26, 4:48 AM
Unknown Object (File)
Wed, Jun 24, 1:27 PM
Unknown Object (File)
May 24 2026, 8:51 PM
Unknown Object (File)
May 24 2026, 8:51 PM
Unknown Object (File)
May 19 2026, 2:33 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
alc
kib
Commits
rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure
Summary

aa3bcaa fixed an edge case invloving mlock() and superpage creation
by creating and inserting a leaf pagetable page for mlock'd superpages.
However, the code does not properly release the reference to the
pagetable page in the error handling path.
This commit fixes the issue by adding calls to 'pmap_abort_ptp'
in the error handling path.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58165
Build 55053: arc lint + arc unit

Event Timeline

bnovkov created this revision.Jun 13 2024, 4:27 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 13 2024, 4:27 PM
bnovkov requested review of this revision.Jun 13 2024, 4:27 PM
Harbormaster completed remote builds in B58165: Diff 139806.Jun 13 2024, 4:27 PM
bnovkov edited the summary of this revision. (Show Details)Jun 13 2024, 4:27 PM
alc accepted this revision.Jun 13 2024, 7:35 PM
This revision is now accepted and ready to land.Jun 13 2024, 7:35 PM
kib accepted this revision.Jun 13 2024, 7:41 PM
markj accepted this revision.Jun 14 2024, 1:54 PM
markj added inline comments.Jun 14 2024, 2:00 PM
sys/amd64/amd64/pmap.c
7599

There are some code paths in this function which handle pdpg == NULL, but I don't think that's possible.

alc added inline comments.Jun 14 2024, 11:03 PM
sys/amd64/amd64/pmap.c
7599

Yes, because pmap != kernel_pmap.

Closed by commit rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure (authored by bnovkov). · Explain WhyJun 16 2024, 4:21 PM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
5 lines

Diff 139806

View Options

sys/amd64/amd64/pmap.c

Loading...