Page MenuHomeFreeBSD
Differential D5418

Bump version of emulated Linux kernel to 2.6.18 in FreeBSD 9
ClosedPublic
Actions

Authored by rene on Feb 24 2016, 8:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 4:29 PM
Unknown Object (File)
Mar 6 2025, 7:32 AM
Unknown Object (File)
Feb 22 2025, 3:25 PM
Unknown Object (File)
Feb 22 2025, 8:27 AM
Unknown Object (File)
Jan 29 2025, 4:01 PM
Unknown Object (File)
Jan 27 2025, 10:39 PM
Unknown Object (File)
Jan 27 2025, 9:23 PM
Unknown Object (File)
Jan 17 2025, 12:27 PM
View All 86 Files
Subscribers
imp
jbeich

Details

Reviewers
dchagin
des
Commits
rS296219: MFC r271982:
Summary

The Linux emulation in FreeBSD 9 (9.3, 9-STABLE) currently reports kernel version 2.6.16, which is too low for the emulators/linux-c6* ports. These ports require kernel version 2.6.18 or later. Change the Linux emulator to report kernel version 2.6.18 instead (sysctl compat.linux.osrelease). This in turn allows us to run the linux-c6-* ports by default on FreeBSD 9 and to remove the Linux Fedora 10 ports which are long past their EOL.

This is a direct patch to stable/9 , as FreeBSD 10 and HEAD emulate Linux kernel 2.6.32 by default.

Test Plan
  1. Build modified Linux emulator for amd64 and i386 (done)
  2. Load modified linux.ko into a VM running FreeBSD 9.3-i386 and run some Linux programs with the linux-c6-* ports (todo, but already tested OK with manually bumping compat.linux.osrelease)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rene updated this revision to Diff 13674.Feb 24 2016, 8:57 AM
rene retitled this revision from to Bump version of emulated Linux kernel to 2.6.18 in FreeBSD 9.
rene updated this object.
rene edited the test plan for this revision. (Show Details)
rene added a reviewer: des.
rene set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2016, 8:57 AM
rene added a comment.Feb 24 2016, 7:32 PM

I tested the patch in a 9.3-i386 VM, the screenshot is available at https://rene-ladan.nl/linux-c6-opera-on-freebsd93.png

rene added a reviewer: dchagin.Feb 25 2016, 8:16 AM
jbeich added a subscriber: jbeich.EditedFeb 25 2016, 3:42 PM

This is a direct patch to stable/9 , as FreeBSD 10 and HEAD emulate Linux kernel 2.6.32 by default.

Before 2.6.32 there was 2.6.18 bump: rS271982 + rS271990 = rS275807 in /stable/10.

rene added a comment.Feb 25 2016, 4:29 PM
In D5418#115923, @jbeich wrote:

This is a direct patch to stable/9 , as FreeBSD 10 and HEAD emulate Linux kernel 2.6.32 by default.

Before 2.6.32 there was 2.6.18 bump: rS271982 + rS271990 = rS275807 in /stable/10.

I didn't notice this before, I will MFC the two commits to stable/9

rene updated this revision to Diff 13743.Feb 25 2016, 10:22 PM

Properly MFC earlier commits as suggested by jbeich.

The revision number/date in UPDATING needs to be updated once this is committed? As the idea is to remove the -f10 ports, a message about this should be added to UPDATING in a follow-up commit.

rene added a comment.Feb 25 2016, 10:25 PM

Mergeinfo added but this does not show up in Phabricator?

As suggested by des, bump __FreeBSD_version in sys/sys/param.h

dchagin accepted this revision.Feb 29 2016, 5:06 PM
dchagin edited edge metadata.
This revision is now accepted and ready to land.Feb 29 2016, 5:06 PM
Closed by commit rS296219: MFC r271982: (authored by rene). · Explain WhyFeb 29 2016, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stable/
9/
8 lines
compat/
linux/
4 lines
sys/
2 lines

Diff 13893

View Options

stable/9/UPDATING

.\" Copyright (c) 1990, 1991, 1993 .\" Copyright (c) 1990, 1991, 1993 The Regents of the University of California.
.\" The Regents of the University of California. All rights reserved. .\" Copyright (c) 2015 Mariusz Zaborski <oshogbo@FreeBSD.org>
.\" All rights reserved.
.\" .\"
.\" This code is derived from software contributed to Berkeley by .\" This code is derived from software contributed to Berkeley by
.\" Chris Torek and the American National Standards Committee X3, .\" Chris Torek and the American National Standards Committee X3,
Context not available.
.\" @(#)fclose.3 8.1 (Berkeley) 6/4/93 .\" @(#)fclose.3 8.1 (Berkeley) 6/4/93
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 22, 2006 .Dd Jun 1, 2015
.Dt FCLOSE 3 .Dt FCLOSE 3
.Os .Os
wblockUnsubmitted
Done
Inline Actions

No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up diffs. I'll try to include some context to make this easier.)

38 the file descriptor will be written to it.

wblock: No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up…
.Sh NAME .Sh NAME
.Nm fclose , .Nm fclose ,
.Nm fdclose ,
wblockUnsubmitted
Done
Inline Actions

Typo: s/arguemnt/argument/

wblock: Typo: s/arguemnt/argument/
wblockUnsubmitted
Done
Inline Actions

Oops, I missed the other typo:
s/diffrent/different/

wblock: Oops, I missed the other typo: s/diffrent/different/
.Nm fcloseall .Nm fcloseall
wblockUnsubmitted
Done
Inline Actions

Needs a comma after this "descriptor", where the pause is located:

42 If the stream does not have an associated file descriptor,

wblock: Needs a comma after this "descriptor", where the pause is located: 42 If the stream does not…
.Nd close a stream .Nd close a stream
.Sh LIBRARY .Sh LIBRARY
Context not available.
.In stdio.h .In stdio.h
.Ft int .Ft int
.Fn fclose "FILE *stream" .Fn fclose "FILE *stream"
.Ft int
.Fn fdclose "FILE *stream" "int *fdp"
.Ft void .Ft void
.Fn fcloseall void .Fn fcloseall void
.Sh DESCRIPTION .Sh DESCRIPTION
Context not available.
.Xr fflush 3 . .Xr fflush 3 .
.Pp .Pp
The The
.Fn fdclose
function is equivalent to
.Fn fclose
except that it does not close the underlying file descriptor.
If
.Fa fdp
is not
jillesUnsubmitted
Done
Inline Actions

Calling the argument fdp instead of fd may make this clearer.

Try:

If
.Fa fd
is not
.Dv NULL ,
the file descriptor will be written to it.

jilles: Calling the argument fdp instead of fd may make this clearer. Try: If .Fa fd is not .Dv NULL…
.Dv NULL ,
jillesUnsubmitted
Done
Inline Actions

The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have an associated file descriptor", possibly with examples like fmemopen(), funopen() and open_memstream().

These words also occur under ERRORS below.

If the stream is not open, the behaviour is not defined and need not be described in the man page.

jilles: The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have…
the file descriptor, will be written to it.
If the
.Fa fdp
arguemnt will be diffrent then NULL the file descriptor will be returned in it,
If the stream does not have an associated file descriptor
wblockUnsubmitted
Done
Inline Actions

Needs a comma after "descriptor".

wblock: Needs a comma after "descriptor".
.Fa fdp
will be set to -1.
This type of stream is created with functions such as
wblockUnsubmitted
Done
Inline Actions

"Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of stream", or maybe it does not even need to be said. "functions like" is confusing, probably should be "such as". Finally, switch to active rather than passive voice by changing "could" to "can" or "is":

Streams are created with functions such as
or
This type of stream is created with functions such as
or even
This type of stream is created with

wblock: "Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of…
.Xr fmemopen 3 ,
.Xr funopen 3 ,
or
.Xr open_memstream 3 .
.Pp
The
.Fn fcloseall .Fn fcloseall
function calls function calls
.Fn fclose .Fn fclose
on all open streams. on all open streams.
.Sh RETURN VALUES .Sh RETURN VALUES
Upon successful completion 0 is returned. .Fn fcloseall
returns no value.
.Pp
wblockUnsubmitted
Done
Inline Actions

Several things:

  1. Not necessary to use "the blah function". After the first time, just say the name of the function: "blah returns..." (no leading "The").
  2. "returns no value" is somewhat ambiguous, could be misread to mean it returns null. "does not return a value" might be more clear.

So:

.Fn fcloseall
does not return a value.

wblock: Several things: 1. Not necessary to use "the blah function". After the first time, just say…
Upon successful completion the
.Fn fclose
and
.Fn fdclose
wblockUnsubmitted
Done
Inline Actions

Start the new sentence on a new line:

99  This is intentional.

100 It makes it easier to make sure programs written under

wblock: Start the new sentence on a new line: 99 This is intentional. 100 It makes it easier to…
functions return 0.
Otherwise, Otherwise,
.Dv EOF .Dv EOF
is returned and the global variable is returned and the global variable
.Va errno .Va errno
is set to indicate the error. is set to indicate the error.
In either case no further access to the stream is possible.
.Sh ERRORS .Sh ERRORS
jillesUnsubmitted
Done
Inline Actions

This change seems unnecessary. It is still the case that there are two situations: success and error.

jilles: This change seems unnecessary. It is still the case that there are two situations: success and…
The The
.Fn fdclose
function shall fail if:
wblockUnsubmitted
Done
Inline Actions

"Shall" implies a recommendation. Probably better as "will".

wblock: "Shall" implies a recommendation. Probably better as "will".
.Bl -tag -width Er
.It Bq Er EOPNOTSUPP
The stream does not have an associated file descriptor.
.Pp
The
.Fn fclose .Fn fclose
function and
may also fail and set .Fn fdclose
functions may also fail and set
.Va errno .Va errno
for any of the errors specified for the routines for any of the errors specified for
.Xr close 2
or
.Xr fflush 3 . .Xr fflush 3 .
.Pp
jillesUnsubmitted
Done
Inline Actions

errno should keep its .Va markup

jilles: errno should keep its .Va markup
The
.Fn fclose
function may also fail and set errno for any of the errors specified for
.Xr close 2.
.Sh NOTES .Sh NOTES
The The
.Fn fclose .Fn fclose
function and
does not handle NULL arguments; they will result in a segmentation .Fn fdclose
violation. functions do not handle NULL arguments in the
This is intentional - it makes it easier to make sure programs written .Fa stream
under variable; this will result in a segmentation violation.
This is intentional. It makes it easier to make sure programs written under
wblockUnsubmitted
Done
Inline Actions

(Missing an "it" after "makes").
Use a full stop rather than an emdash:

This is intentional.
It makes it easier to make sure programs written under

wblock: (Missing an "it" after "makes"). Use a full stop rather than an emdash: This is intentional.
.Fx .Fx
are bug free. are bug free.
This behaviour is an implementation detail, and programs should not This behaviour is an implementation detail, and programs should not
Context not available.
function function
conforms to conforms to
.St -isoC . .St -isoC .
.Pp .Sh HISTORY
jillesUnsubmitted
Done
Inline Actions

This should be .Sh HISTORY.

jilles: This should be `.Sh HISTORY`.
The The
.Fn fcloseall .Fn fcloseall
function first appeared in function first appeared in
.Fx 7.0 . .Fx 7.0 .
.Pp
The
.Fn fdclose
function first appeared in
.Fx 11.0 .
Context not available.
View Options

stable/9/sys

.\" Copyright (c) 1990, 1991, 1993 .\" Copyright (c) 1990, 1991, 1993 The Regents of the University of California.
.\" The Regents of the University of California. All rights reserved. .\" Copyright (c) 2015 Mariusz Zaborski <oshogbo@FreeBSD.org>
.\" All rights reserved.
.\" .\"
.\" This code is derived from software contributed to Berkeley by .\" This code is derived from software contributed to Berkeley by
.\" Chris Torek and the American National Standards Committee X3, .\" Chris Torek and the American National Standards Committee X3,
Context not available.
.\" @(#)fclose.3 8.1 (Berkeley) 6/4/93 .\" @(#)fclose.3 8.1 (Berkeley) 6/4/93
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 22, 2006 .Dd Jun 1, 2015
.Dt FCLOSE 3 .Dt FCLOSE 3
.Os .Os
wblockUnsubmitted
Done
Inline Actions

No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up diffs. I'll try to include some context to make this easier.)

38 the file descriptor will be written to it.

wblock: No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up…
.Sh NAME .Sh NAME
.Nm fclose , .Nm fclose ,
.Nm fdclose ,
wblockUnsubmitted
Done
Inline Actions

Typo: s/arguemnt/argument/

wblock: Typo: s/arguemnt/argument/
wblockUnsubmitted
Done
Inline Actions

Oops, I missed the other typo:
s/diffrent/different/

wblock: Oops, I missed the other typo: s/diffrent/different/
.Nm fcloseall .Nm fcloseall
wblockUnsubmitted
Done
Inline Actions

Needs a comma after this "descriptor", where the pause is located:

42 If the stream does not have an associated file descriptor,

wblock: Needs a comma after this "descriptor", where the pause is located: 42 If the stream does not…
.Nd close a stream .Nd close a stream
.Sh LIBRARY .Sh LIBRARY
Context not available.
.In stdio.h .In stdio.h
.Ft int .Ft int
.Fn fclose "FILE *stream" .Fn fclose "FILE *stream"
.Ft int
.Fn fdclose "FILE *stream" "int *fdp"
.Ft void .Ft void
.Fn fcloseall void .Fn fcloseall void
.Sh DESCRIPTION .Sh DESCRIPTION
Context not available.
.Xr fflush 3 . .Xr fflush 3 .
.Pp .Pp
The The
.Fn fdclose
function is equivalent to
.Fn fclose
except that it does not close the underlying file descriptor.
If
.Fa fdp
is not
jillesUnsubmitted
Done
Inline Actions

Calling the argument fdp instead of fd may make this clearer.

Try:

If
.Fa fd
is not
.Dv NULL ,
the file descriptor will be written to it.

jilles: Calling the argument fdp instead of fd may make this clearer. Try: If .Fa fd is not .Dv NULL…
.Dv NULL ,
jillesUnsubmitted
Done
Inline Actions

The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have an associated file descriptor", possibly with examples like fmemopen(), funopen() and open_memstream().

These words also occur under ERRORS below.

If the stream is not open, the behaviour is not defined and need not be described in the man page.

jilles: The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have…
the file descriptor, will be written to it.
If the
.Fa fdp
arguemnt will be diffrent then NULL the file descriptor will be returned in it,
If the stream does not have an associated file descriptor
wblockUnsubmitted
Done
Inline Actions

Needs a comma after "descriptor".

wblock: Needs a comma after "descriptor".
.Fa fdp
will be set to -1.
This type of stream is created with functions such as
wblockUnsubmitted
Done
Inline Actions

"Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of stream", or maybe it does not even need to be said. "functions like" is confusing, probably should be "such as". Finally, switch to active rather than passive voice by changing "could" to "can" or "is":

Streams are created with functions such as
or
This type of stream is created with functions such as
or even
This type of stream is created with

wblock: "Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of…
.Xr fmemopen 3 ,
.Xr funopen 3 ,
or
.Xr open_memstream 3 .
.Pp
The
.Fn fcloseall .Fn fcloseall
function calls function calls
.Fn fclose .Fn fclose
on all open streams. on all open streams.
.Sh RETURN VALUES .Sh RETURN VALUES
Upon successful completion 0 is returned. .Fn fcloseall
returns no value.
.Pp
wblockUnsubmitted
Done
Inline Actions

Several things:

  1. Not necessary to use "the blah function". After the first time, just say the name of the function: "blah returns..." (no leading "The").
  2. "returns no value" is somewhat ambiguous, could be misread to mean it returns null. "does not return a value" might be more clear.

So:

.Fn fcloseall
does not return a value.

wblock: Several things: 1. Not necessary to use "the blah function". After the first time, just say…
Upon successful completion the
.Fn fclose
and
.Fn fdclose
wblockUnsubmitted
Done
Inline Actions

Start the new sentence on a new line:

99  This is intentional.

100 It makes it easier to make sure programs written under

wblock: Start the new sentence on a new line: 99 This is intentional. 100 It makes it easier to…
functions return 0.
Otherwise, Otherwise,
.Dv EOF .Dv EOF
is returned and the global variable is returned and the global variable
.Va errno .Va errno
is set to indicate the error. is set to indicate the error.
In either case no further access to the stream is possible.
.Sh ERRORS .Sh ERRORS
jillesUnsubmitted
Done
Inline Actions

This change seems unnecessary. It is still the case that there are two situations: success and error.

jilles: This change seems unnecessary. It is still the case that there are two situations: success and…
The The
.Fn fdclose
function shall fail if:
wblockUnsubmitted
Done
Inline Actions

"Shall" implies a recommendation. Probably better as "will".

wblock: "Shall" implies a recommendation. Probably better as "will".
.Bl -tag -width Er
.It Bq Er EOPNOTSUPP
The stream does not have an associated file descriptor.
.Pp
The
.Fn fclose .Fn fclose
function and
may also fail and set .Fn fdclose
functions may also fail and set
.Va errno .Va errno
for any of the errors specified for the routines for any of the errors specified for
.Xr close 2
or
.Xr fflush 3 . .Xr fflush 3 .
.Pp
jillesUnsubmitted
Done
Inline Actions

errno should keep its .Va markup

jilles: errno should keep its .Va markup
The
.Fn fclose
function may also fail and set errno for any of the errors specified for
.Xr close 2.
.Sh NOTES .Sh NOTES
The The
.Fn fclose .Fn fclose
function and
does not handle NULL arguments; they will result in a segmentation .Fn fdclose
violation. functions do not handle NULL arguments in the
This is intentional - it makes it easier to make sure programs written .Fa stream
under variable; this will result in a segmentation violation.
This is intentional. It makes it easier to make sure programs written under
wblockUnsubmitted
Done
Inline Actions

(Missing an "it" after "makes").
Use a full stop rather than an emdash:

This is intentional.
It makes it easier to make sure programs written under

wblock: (Missing an "it" after "makes"). Use a full stop rather than an emdash: This is intentional.
.Fx .Fx
are bug free. are bug free.
This behaviour is an implementation detail, and programs should not This behaviour is an implementation detail, and programs should not
Context not available.
function function
conforms to conforms to
.St -isoC . .St -isoC .
.Pp .Sh HISTORY
jillesUnsubmitted
Done
Inline Actions

This should be .Sh HISTORY.

jilles: This should be `.Sh HISTORY`.
The The
.Fn fcloseall .Fn fcloseall
function first appeared in function first appeared in
.Fx 7.0 . .Fx 7.0 .
.Pp
The
.Fn fdclose
function first appeared in
.Fx 11.0 .
Context not available.
View Options

stable/9/sys/compat/linux/linux_mib.c

.\" Copyright (c) 1990, 1991, 1993 .\" Copyright (c) 1990, 1991, 1993 The Regents of the University of California.
.\" The Regents of the University of California. All rights reserved. .\" Copyright (c) 2015 Mariusz Zaborski <oshogbo@FreeBSD.org>
.\" All rights reserved.
.\" .\"
.\" This code is derived from software contributed to Berkeley by .\" This code is derived from software contributed to Berkeley by
.\" Chris Torek and the American National Standards Committee X3, .\" Chris Torek and the American National Standards Committee X3,
Context not available.
.\" @(#)fclose.3 8.1 (Berkeley) 6/4/93 .\" @(#)fclose.3 8.1 (Berkeley) 6/4/93
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 22, 2006 .Dd Jun 1, 2015
.Dt FCLOSE 3 .Dt FCLOSE 3
.Os .Os
wblockUnsubmitted
Done
Inline Actions

No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up diffs. I'll try to include some context to make this easier.)

38 the file descriptor will be written to it.

wblock: No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up…
.Sh NAME .Sh NAME
.Nm fclose , .Nm fclose ,
.Nm fdclose ,
wblockUnsubmitted
Done
Inline Actions

Typo: s/arguemnt/argument/

wblock: Typo: s/arguemnt/argument/
wblockUnsubmitted
Done
Inline Actions

Oops, I missed the other typo:
s/diffrent/different/

wblock: Oops, I missed the other typo: s/diffrent/different/
.Nm fcloseall .Nm fcloseall
wblockUnsubmitted
Done
Inline Actions

Needs a comma after this "descriptor", where the pause is located:

42 If the stream does not have an associated file descriptor,

wblock: Needs a comma after this "descriptor", where the pause is located: 42 If the stream does not…
.Nd close a stream .Nd close a stream
.Sh LIBRARY .Sh LIBRARY
Context not available.
.In stdio.h .In stdio.h
.Ft int .Ft int
.Fn fclose "FILE *stream" .Fn fclose "FILE *stream"
.Ft int
.Fn fdclose "FILE *stream" "int *fdp"
.Ft void .Ft void
.Fn fcloseall void .Fn fcloseall void
.Sh DESCRIPTION .Sh DESCRIPTION
Context not available.
.Xr fflush 3 . .Xr fflush 3 .
.Pp .Pp
The The
.Fn fdclose
function is equivalent to
.Fn fclose
except that it does not close the underlying file descriptor.
If
.Fa fdp
is not
jillesUnsubmitted
Done
Inline Actions

Calling the argument fdp instead of fd may make this clearer.

Try:

If
.Fa fd
is not
.Dv NULL ,
the file descriptor will be written to it.

jilles: Calling the argument fdp instead of fd may make this clearer. Try: If .Fa fd is not .Dv NULL…
.Dv NULL ,
jillesUnsubmitted
Done
Inline Actions

The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have an associated file descriptor", possibly with examples like fmemopen(), funopen() and open_memstream().

These words also occur under ERRORS below.

If the stream is not open, the behaviour is not defined and need not be described in the man page.

jilles: The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have…
the file descriptor, will be written to it.
If the
.Fa fdp
arguemnt will be diffrent then NULL the file descriptor will be returned in it,
If the stream does not have an associated file descriptor
wblockUnsubmitted
Done
Inline Actions

Needs a comma after "descriptor".

wblock: Needs a comma after "descriptor".
.Fa fdp
will be set to -1.
This type of stream is created with functions such as
wblockUnsubmitted
Done
Inline Actions

"Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of stream", or maybe it does not even need to be said. "functions like" is confusing, probably should be "such as". Finally, switch to active rather than passive voice by changing "could" to "can" or "is":

Streams are created with functions such as
or
This type of stream is created with functions such as
or even
This type of stream is created with

wblock: "Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of…
.Xr fmemopen 3 ,
.Xr funopen 3 ,
or
.Xr open_memstream 3 .
.Pp
The
.Fn fcloseall .Fn fcloseall
function calls function calls
.Fn fclose .Fn fclose
on all open streams. on all open streams.
.Sh RETURN VALUES .Sh RETURN VALUES
Upon successful completion 0 is returned. .Fn fcloseall
returns no value.
.Pp
wblockUnsubmitted
Done
Inline Actions

Several things:

  1. Not necessary to use "the blah function". After the first time, just say the name of the function: "blah returns..." (no leading "The").
  2. "returns no value" is somewhat ambiguous, could be misread to mean it returns null. "does not return a value" might be more clear.

So:

.Fn fcloseall
does not return a value.

wblock: Several things: 1. Not necessary to use "the blah function". After the first time, just say…
Upon successful completion the
.Fn fclose
and
.Fn fdclose
wblockUnsubmitted
Done
Inline Actions

Start the new sentence on a new line:

99  This is intentional.

100 It makes it easier to make sure programs written under

wblock: Start the new sentence on a new line: 99 This is intentional. 100 It makes it easier to…
functions return 0.
Otherwise, Otherwise,
.Dv EOF .Dv EOF
is returned and the global variable is returned and the global variable
.Va errno .Va errno
is set to indicate the error. is set to indicate the error.
In either case no further access to the stream is possible.
.Sh ERRORS .Sh ERRORS
jillesUnsubmitted
Done
Inline Actions

This change seems unnecessary. It is still the case that there are two situations: success and error.

jilles: This change seems unnecessary. It is still the case that there are two situations: success and…
The The
.Fn fdclose
function shall fail if:
wblockUnsubmitted
Done
Inline Actions

"Shall" implies a recommendation. Probably better as "will".

wblock: "Shall" implies a recommendation. Probably better as "will".
.Bl -tag -width Er
.It Bq Er EOPNOTSUPP
The stream does not have an associated file descriptor.
.Pp
The
.Fn fclose .Fn fclose
function and
may also fail and set .Fn fdclose
functions may also fail and set
.Va errno .Va errno
for any of the errors specified for the routines for any of the errors specified for
.Xr close 2
or
.Xr fflush 3 . .Xr fflush 3 .
.Pp
jillesUnsubmitted
Done
Inline Actions

errno should keep its .Va markup

jilles: errno should keep its .Va markup
The
.Fn fclose
function may also fail and set errno for any of the errors specified for
.Xr close 2.
.Sh NOTES .Sh NOTES
The The
.Fn fclose .Fn fclose
function and
does not handle NULL arguments; they will result in a segmentation .Fn fdclose
violation. functions do not handle NULL arguments in the
This is intentional - it makes it easier to make sure programs written .Fa stream
under variable; this will result in a segmentation violation.
This is intentional. It makes it easier to make sure programs written under
wblockUnsubmitted
Done
Inline Actions

(Missing an "it" after "makes").
Use a full stop rather than an emdash:

This is intentional.
It makes it easier to make sure programs written under

wblock: (Missing an "it" after "makes"). Use a full stop rather than an emdash: This is intentional.
.Fx .Fx
are bug free. are bug free.
This behaviour is an implementation detail, and programs should not This behaviour is an implementation detail, and programs should not
Context not available.
function function
conforms to conforms to
.St -isoC . .St -isoC .
.Pp .Sh HISTORY
jillesUnsubmitted
Done
Inline Actions

This should be .Sh HISTORY.

jilles: This should be `.Sh HISTORY`.
The The
.Fn fcloseall .Fn fcloseall
function first appeared in function first appeared in
.Fx 7.0 . .Fx 7.0 .
.Pp
The
.Fn fdclose
function first appeared in
.Fx 11.0 .
Context not available.
View Options

stable/9/sys/sys/param.h

.\" Copyright (c) 1990, 1991, 1993 .\" Copyright (c) 1990, 1991, 1993 The Regents of the University of California.
.\" The Regents of the University of California. All rights reserved. .\" Copyright (c) 2015 Mariusz Zaborski <oshogbo@FreeBSD.org>
.\" All rights reserved.
.\" .\"
.\" This code is derived from software contributed to Berkeley by .\" This code is derived from software contributed to Berkeley by
.\" Chris Torek and the American National Standards Committee X3, .\" Chris Torek and the American National Standards Committee X3,
Context not available.
.\" @(#)fclose.3 8.1 (Berkeley) 6/4/93 .\" @(#)fclose.3 8.1 (Berkeley) 6/4/93
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 22, 2006 .Dd Jun 1, 2015
.Dt FCLOSE 3 .Dt FCLOSE 3
.Os .Os
wblockUnsubmitted
Done
Inline Actions

No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up diffs. I'll try to include some context to make this easier.)

38 the file descriptor will be written to it.

wblock: No comma after "descriptor" here. (This might be due to phabricator "helping" by mixing up…
.Sh NAME .Sh NAME
.Nm fclose , .Nm fclose ,
.Nm fdclose ,
wblockUnsubmitted
Done
Inline Actions

Typo: s/arguemnt/argument/

wblock: Typo: s/arguemnt/argument/
wblockUnsubmitted
Done
Inline Actions

Oops, I missed the other typo:
s/diffrent/different/

wblock: Oops, I missed the other typo: s/diffrent/different/
.Nm fcloseall .Nm fcloseall
wblockUnsubmitted
Done
Inline Actions

Needs a comma after this "descriptor", where the pause is located:

42 If the stream does not have an associated file descriptor,

wblock: Needs a comma after this "descriptor", where the pause is located: 42 If the stream does not…
.Nd close a stream .Nd close a stream
.Sh LIBRARY .Sh LIBRARY
Context not available.
.In stdio.h .In stdio.h
.Ft int .Ft int
.Fn fclose "FILE *stream" .Fn fclose "FILE *stream"
.Ft int
.Fn fdclose "FILE *stream" "int *fdp"
.Ft void .Ft void
.Fn fcloseall void .Fn fcloseall void
.Sh DESCRIPTION .Sh DESCRIPTION
Context not available.
.Xr fflush 3 . .Xr fflush 3 .
.Pp .Pp
The The
.Fn fdclose
function is equivalent to
.Fn fclose
except that it does not close the underlying file descriptor.
If
.Fa fdp
is not
jillesUnsubmitted
Done
Inline Actions

Calling the argument fdp instead of fd may make this clearer.

Try:

If
.Fa fd
is not
.Dv NULL ,
the file descriptor will be written to it.

jilles: Calling the argument fdp instead of fd may make this clearer. Try: If .Fa fd is not .Dv NULL…
.Dv NULL ,
jillesUnsubmitted
Done
Inline Actions

The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have an associated file descriptor", possibly with examples like fmemopen(), funopen() and open_memstream().

These words also occur under ERRORS below.

If the stream is not open, the behaviour is not defined and need not be described in the man page.

jilles: The words "non-standard close method" may be unclear. Perhaps say "If the stream does not have…
the file descriptor, will be written to it.
If the
.Fa fdp
arguemnt will be diffrent then NULL the file descriptor will be returned in it,
If the stream does not have an associated file descriptor
wblockUnsubmitted
Done
Inline Actions

Needs a comma after "descriptor".

wblock: Needs a comma after "descriptor".
.Fa fdp
will be set to -1.
This type of stream is created with functions such as
wblockUnsubmitted
Done
Inline Actions

"Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of stream", or maybe it does not even need to be said. "functions like" is confusing, probably should be "such as". Finally, switch to active rather than passive voice by changing "could" to "can" or "is":

Streams are created with functions such as
or
This type of stream is created with functions such as
or even
This type of stream is created with

wblock: "Such stream" should be "Such a stream", but it's a little confusing, maybe "This type of…
.Xr fmemopen 3 ,
.Xr funopen 3 ,
or
.Xr open_memstream 3 .
.Pp
The
.Fn fcloseall .Fn fcloseall
function calls function calls
.Fn fclose .Fn fclose
on all open streams. on all open streams.
.Sh RETURN VALUES .Sh RETURN VALUES
Upon successful completion 0 is returned. .Fn fcloseall
returns no value.
.Pp
wblockUnsubmitted
Done
Inline Actions

Several things:

  1. Not necessary to use "the blah function". After the first time, just say the name of the function: "blah returns..." (no leading "The").
  2. "returns no value" is somewhat ambiguous, could be misread to mean it returns null. "does not return a value" might be more clear.

So:

.Fn fcloseall
does not return a value.

wblock: Several things: 1. Not necessary to use "the blah function". After the first time, just say…
Upon successful completion the
.Fn fclose
and
.Fn fdclose
wblockUnsubmitted
Done
Inline Actions

Start the new sentence on a new line:

99  This is intentional.

100 It makes it easier to make sure programs written under

wblock: Start the new sentence on a new line: 99 This is intentional. 100 It makes it easier to…
functions return 0.
Otherwise, Otherwise,
.Dv EOF .Dv EOF
is returned and the global variable is returned and the global variable
.Va errno .Va errno
is set to indicate the error. is set to indicate the error.
In either case no further access to the stream is possible.
.Sh ERRORS .Sh ERRORS
jillesUnsubmitted
Done
Inline Actions

This change seems unnecessary. It is still the case that there are two situations: success and error.

jilles: This change seems unnecessary. It is still the case that there are two situations: success and…
The The
.Fn fdclose
function shall fail if:
wblockUnsubmitted
Done
Inline Actions

"Shall" implies a recommendation. Probably better as "will".

wblock: "Shall" implies a recommendation. Probably better as "will".
.Bl -tag -width Er
.It Bq Er EOPNOTSUPP
The stream does not have an associated file descriptor.
.Pp
The
.Fn fclose .Fn fclose
function and
may also fail and set .Fn fdclose
functions may also fail and set
.Va errno .Va errno
for any of the errors specified for the routines for any of the errors specified for
.Xr close 2
or
.Xr fflush 3 . .Xr fflush 3 .
.Pp
jillesUnsubmitted
Done
Inline Actions

errno should keep its .Va markup

jilles: errno should keep its .Va markup
The
.Fn fclose
function may also fail and set errno for any of the errors specified for
.Xr close 2.
.Sh NOTES .Sh NOTES
The The
.Fn fclose .Fn fclose
function and
does not handle NULL arguments; they will result in a segmentation .Fn fdclose
violation. functions do not handle NULL arguments in the
This is intentional - it makes it easier to make sure programs written .Fa stream
under variable; this will result in a segmentation violation.
This is intentional. It makes it easier to make sure programs written under
wblockUnsubmitted
Done
Inline Actions

(Missing an "it" after "makes").
Use a full stop rather than an emdash:

This is intentional.
It makes it easier to make sure programs written under

wblock: (Missing an "it" after "makes"). Use a full stop rather than an emdash: This is intentional.
.Fx .Fx
are bug free. are bug free.
This behaviour is an implementation detail, and programs should not This behaviour is an implementation detail, and programs should not
Context not available.
function function
conforms to conforms to
.St -isoC . .St -isoC .
.Pp .Sh HISTORY
jillesUnsubmitted
Done
Inline Actions

This should be .Sh HISTORY.

jilles: This should be `.Sh HISTORY`.
The The
.Fn fcloseall .Fn fcloseall
function first appeared in function first appeared in
.Fx 7.0 . .Fx 7.0 .
.Pp
The
.Fn fdclose
function first appeared in
.Fx 11.0 .
Context not available.