Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 57602 Build 54490: arc lint + arc unit
Event Timeline
you negotiate it as an extension, and then it's used to switch STA keys without dropping frames.
Otherwise there's a window when you change STA keys where you'd have to stop traffic, flip the keys over, and then start traffic again, and that causes hiccups in traffic flows. Super annoying for low latency operations like VoIP.
During association with the AP, sw/hw keys (indexes) are set. And before tx, the hw key is selected by sw key's index returned from ieee80211_crypto_get_txkey(), same way as without LKPI_80211_HW_CRYPTO.
Would you please elaborate "you negotiate it as an extension"? I am not fully following up with your comment. I thought a frame only needs one key, as a key is selected every time the lkpi_80211_txq_tx_one() is called. Why would a frame need to switch STA keys?
| sys/compat/linuxkpi/common/src/linux_80211.c | ||
|---|---|---|
| 864 | Should this be asserted/logged after the key alloc/set call? Since if the driver hasn't set this to anything you're gonna have big problems? | |
| sys/compat/linuxkpi/common/src/linux_80211.c | ||
|---|---|---|
| 751 | This should be no longer needed as of 0936c648ad0ee. | |
| 813 | Similarly here. | |