sysctl: Make sysctl_ctx_free() a bit safer
ClosedPublic
Actions

Authored by markj on May 1 2024, 12:00 PM.

Tags

None

Referenced Files

	F102926280: D45041.id137940.diff
	Mon, Nov 18, 8:14 PM

	Unknown Object (File)
	Tue, Nov 12, 10:27 PM

	Unknown Object (File)
	Tue, Nov 12, 9:46 PM

	Unknown Object (File)
	Sep 21 2024, 9:46 AM

	Unknown Object (File)
	Sep 18 2024, 4:44 PM

	Unknown Object (File)
	Sep 13 2024, 6:56 AM

	Unknown Object (File)
	Sep 7 2024, 9:26 PM

	Unknown Object (File)
	Sep 7 2024, 9:26 PM

View All 22 Files

Subscribers

imp

olce

Details

Reviewers

thj
emaste

Commits

rG24268f262b41: sysctl: Make sysctl_ctx_free() a bit safer
rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer

Summary

Clear the list before returning so that it's idempotent when it
succeeds.

While here, use TAILQ_FOREACH_SAFE in the loop which unregisters OIDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 1 2024, 12:00 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMay 1 2024, 12:00 PM

markj requested review of this revision.May 1 2024, 12:00 PM

Harbormaster completed remote builds in B57494: Diff 137940.May 1 2024, 12:00 PM

thj accepted this revision.May 1 2024, 12:03 PM

This revision is now accepted and ready to land.May 1 2024, 12:03 PM

emaste accepted this revision.May 1 2024, 12:13 PM

Closed by commit rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer (authored by markj). · Explain WhyMay 2 2024, 8:02 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer.

markj added a commit: rG24268f262b41: sysctl: Make sysctl_ctx_free() a bit safer.May 11 2024, 2:17 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sysctl.c

6 lines

Diff 138040

View Options

sysctl: Make sysctl_ctx_free() a bit saferClosedPublicActions