vm: Fix error handling in vm_thread_stack_back()
ClosedPublic
Actions

Authored by markj on Apr 29 2024, 11:56 PM.

Details

Reviewers

bnovkov
alc
kib

Commits

rG661a83f9bf9f: vm: Fix error handling in vm_thread_stack_back()

Summary

vm_object_page_remove() wants to busy the page, but that won't work
here. (Kernel stack pages are always busy.)

Make the error handling path look more like vm_thread_stack_dispose().

Reported by: pho
Fixes: 7a79d0669761 ("vm: improve kstack_object pindex calculation to avoid pindex holes")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57456
Build 54344: arc lint + arc unit

Event Timeline

markj created this revision.Apr 29 2024, 11:56 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2024, 11:56 PM

markj requested review of this revision.Apr 29 2024, 11:56 PM

Harbormaster completed remote builds in B57456: Diff 137860.Apr 29 2024, 11:56 PM

kib accepted this revision.Apr 30 2024, 12:19 AM

kib added inline comments.

sys/vm/vm_glue.c
635	This blank line is not needed.

This revision is now accepted and ready to land.Apr 30 2024, 12:19 AM

markj marked an inline comment as done.Apr 30 2024, 12:20 AM

bnovkov accepted this revision.Apr 30 2024, 7:29 AM

Closed by commit rG661a83f9bf9f: vm: Fix error handling in vm_thread_stack_back() (authored by markj). · Explain WhyApr 30 2024, 1:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG661a83f9bf9f: vm: Fix error handling in vm_thread_stack_back().

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_glue.c

7 lines

Diff 137860

View Options

vm: Fix error handling in vm_thread_stack_back()ClosedPublicActions