Page MenuHomeFreeBSD
Differential D44998

sound: Convert pcm_chn_add() to void
ClosedPublic
Actions

Authored by christos on Apr 28 2024, 5:32 PM.
Tags
None
Referenced Files
F108687294: D44998.id138174.diff
Mon, Jan 27, 7:54 AM
F108592695: D44998.id138174.diff
Sun, Jan 26, 6:02 PM
F108574115: D44998.diff
Sun, Jan 26, 12:37 PM
Unknown Object (File)
Sat, Jan 25, 1:49 PM
Unknown Object (File)
Sat, Jan 25, 1:36 PM
Unknown Object (File)
Sat, Jan 25, 10:42 AM
Unknown Object (File)
Thu, Jan 23, 6:45 PM
Unknown Object (File)
Thu, Jan 23, 6:34 PM
View All 55 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG2c53a4bbcb17: sound: Convert pcm_chn_add() to void
rG139bcec852cf: sound: Convert pcm_chn_add() to void
Summary

It always returns 0.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57432
Build 54320: arc lint + arc unit

Event Timeline

christos created this revision.Apr 28 2024, 5:32 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 28 2024, 5:32 PM
christos requested review of this revision.Apr 28 2024, 5:32 PM
Harbormaster completed remote builds in B57432: Diff 137785.Apr 28 2024, 5:32 PM
christos added a parent revision: D44994: sound: Add __assert_unreachable() to default cases in pcm_chn_add() and pcm_chn_remove().Apr 28 2024, 5:32 PM
christos updated this revision to Diff 137786.Apr 28 2024, 5:35 PM

Fix compilation error.

Harbormaster completed remote builds in B57433: Diff 137786.Apr 28 2024, 5:35 PM
emaste accepted this revision.Apr 28 2024, 7:12 PM

OK

This revision is now accepted and ready to land.Apr 28 2024, 7:12 PM
markj accepted this revision.Apr 30 2024, 12:05 AM
markj added inline comments.
sys/dev/sound/pcm/vchan.c
709

It would be a bit cleaner to initialize ret either at the beginning of the function, or further down where we check parent_caps == NULL.

christos marked an inline comment as done.Apr 30 2024, 12:27 AM
Closed by commit rG139bcec852cf: sound: Convert pcm_chn_add() to void (authored by christos). · Explain WhyMay 6 2024, 6:37 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG139bcec852cf: sound: Convert pcm_chn_add() to void.
christos added a commit: rG2c53a4bbcb17: sound: Convert pcm_chn_add() to void.May 17 2024, 7:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines
14 lines
7 lines

Diff 137785

View Options

sys/dev/sound/pcm/sound.h

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...
View Options

sys/dev/sound/pcm/vchan.c

Loading...