Page MenuHomeFreeBSD
Differential D44982

date: Correctly check outcome of mktime().
ClosedPublic
Actions

Authored by des on Apr 27 2024, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 13, 8:05 AM
Unknown Object (File)
Sat, Dec 13, 3:25 AM
Unknown Object (File)
Sat, Dec 13, 2:49 AM
Unknown Object (File)
Nov 28 2025, 2:22 AM
Unknown Object (File)
Nov 19 2025, 9:34 PM
Unknown Object (File)
Nov 12 2025, 10:41 PM
Unknown Object (File)
Nov 11 2025, 7:24 AM
Unknown Object (File)
Nov 5 2025, 5:04 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
0mp
markj
Commits
rGf2ec4bd306ac: date: Correctly check outcome of mktime().
rGdafb424b8d44: date: Correctly check outcome of mktime().
Summary

X-MFC-With: 7b390cb63689

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 27 2024, 3:47 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 27 2024, 3:47 PM
des requested review of this revision.Apr 27 2024, 3:47 PM
Harbormaster completed remote builds in B57414: Diff 137754.Apr 27 2024, 3:47 PM
markj accepted this revision.Apr 27 2024, 3:53 PM
This revision is now accepted and ready to land.Apr 27 2024, 3:53 PM
markj added a comment.Apr 27 2024, 3:55 PM

X-MFC-With: 7b390cb63689

We typically use a Fixes: tag these days. It's useful to be consistent, if only for the benefit of tooling that can identify MFCs of commits without a follow-up fixup commit.

des added a comment.Apr 28 2024, 4:29 PM
In D44982#1025536, @markj wrote:

X-MFC-With: 7b390cb63689

We typically use a Fixes: tag these days.

It doesn't actually fix a bug in 7b390cb63689. The bug has been there since the 1990s.

Closed by commit rGdafb424b8d44: date: Correctly check outcome of mktime(). (authored by des). · Explain WhyApr 28 2024, 5:13 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGdafb424b8d44: date: Correctly check outcome of mktime()..
0mp added a commit: rGf2ec4bd306ac: date: Correctly check outcome of mktime()..May 2 2024, 8:53 PM

Revision Contents
Changeset List

PathSize
bin/
date/
4 lines

Diff 137782

View Options

bin/date/date.c

Loading...