date: Correctly check outcome of mktime().
ClosedPublic
Actions

Authored by des on Apr 27 2024, 3:47 PM.

Details

Reviewers

0mp
markj

Commits

rGf2ec4bd306ac: date: Correctly check outcome of mktime().
rGdafb424b8d44: date: Correctly check outcome of mktime().

Summary

X-MFC-With: 7b390cb63689

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57414
Build 54302: arc lint + arc unit

Event Timeline

des created this revision.Apr 27 2024, 3:47 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2024, 3:47 PM

des requested review of this revision.Apr 27 2024, 3:47 PM

Harbormaster completed remote builds in B57414: Diff 137754.Apr 27 2024, 3:47 PM

markj accepted this revision.Apr 27 2024, 3:53 PM

This revision is now accepted and ready to land.Apr 27 2024, 3:53 PM

X-MFC-With: 7b390cb63689

We typically use a Fixes: tag these days. It's useful to be consistent, if only for the benefit of tooling that can identify MFCs of commits without a follow-up fixup commit.

In D44982#1025536, @markj wrote:

X-MFC-With: 7b390cb63689

We typically use a Fixes: tag these days.

It doesn't actually fix a bug in 7b390cb63689. The bug has been there since the 1990s.

Closed by commit rGdafb424b8d44: date: Correctly check outcome of mktime(). (authored by des). · Explain WhyApr 28 2024, 5:13 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGdafb424b8d44: date: Correctly check outcome of mktime()..

0mp added a commit: rGf2ec4bd306ac: date: Correctly check outcome of mktime()..Thu, May 2, 8:53 PM

Revision Contents
Changeset List

Path

Size

bin/

date/

date.c

4 lines

Diff 137754

View Options

date: Correctly check outcome of mktime().ClosedPublicActions