Restore ThunderX Pass1.1 PCI changes removed by r295962
ClosedPublic
Actions

Authored by wma on Feb 26 2016, 7:59 AM.

Details

Reviewers

zbb
emaste
jhb

Commits

rS296091: Restore ThunderX Pass1.1 PCI changes removed by r295962

Summary

If Enhanced Allocation is not used, we can't allocate any random
range. All internal devices have hardcoded place where they can
be located within PCI address space. Fortunately, we can read
this value from BAR.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma updated this revision to Diff 13761.Feb 26 2016, 7:59 AM

wma retitled this revision from to Restore ThunderX Pass1.1 PCI changes removed by r295962.

wma updated this object.

wma edited the test plan for this revision. (Show Details)

wma added a reviewer: zbb.

wma set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptFeb 26 2016, 7:59 AM

wma added a reviewer: emaste.Feb 26 2016, 8:01 AM

Cleaned up the patch.

zbb added inline comments.Feb 26 2016, 11:04 AM

sys/arm64/cavium/thunder_pcie_common.c
168	IMHO this should be moved to `sys/arm64/cavium/thunder_pcie_fdt.c` as we return with the call to `pci_host_generic_alloc_resource()` anyway.
sys/arm64/cavium/thunder_pcie_fdt.c
66	If you move the `FDT` code (mentioned above) here you can `static` both and have only `thunder_pcie_fdt_alloc_res` or smth. here.