Page MenuHomeFreeBSD
Differential D44840

sound: Call device_get_name() and device_get_unit() only once in mixer_init()
ClosedPublic
Actions

Authored by christos on Apr 18 2024, 5:42 PM.
Tags
None
Referenced Files
F102656372: D44840.diff
Fri, Nov 15, 10:39 AM
Unknown Object (File)
Wed, Nov 13, 6:37 AM
Unknown Object (File)
Fri, Oct 18, 3:03 PM
Unknown Object (File)
Oct 2 2024, 7:31 AM
Unknown Object (File)
Oct 1 2024, 4:46 AM
Unknown Object (File)
Sep 30 2024, 7:11 PM
Unknown Object (File)
Sep 30 2024, 2:04 PM
Unknown Object (File)
Sep 25 2024, 8:55 AM
View All 25 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG69707d9f5091: sound: Call device_get_name() and device_get_unit() only once in mixer_init()
rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init()
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57197
Build 54085: arc lint + arc unit

Event Timeline

christos created this revision.Apr 18 2024, 5:42 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2024, 5:42 PM
christos requested review of this revision.Apr 18 2024, 5:42 PM
Harbormaster completed remote builds in B57179: Diff 137318.Apr 18 2024, 5:42 PM
emaste added inline comments.Apr 18 2024, 5:51 PM
sys/dev/sound/pcm/mixer.c
736–740

probably swap the order here just for consistency (we think of <name><unit>)

christos updated this revision to Diff 137337.Apr 18 2024, 6:05 PM
christos marked an inline comment as done.

Address Ed's comment.

Harbormaster completed remote builds in B57197: Diff 137337.Apr 18 2024, 6:05 PM
emaste accepted this revision.Apr 18 2024, 6:16 PM
This revision is now accepted and ready to land.Apr 18 2024, 6:16 PM
markj accepted this revision.Apr 18 2024, 7:10 PM
Closed by commit rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init() (authored by christos). · Explain WhyApr 18 2024, 8:36 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG41ab202ff74e: sound: Call device_get_name() and device_get_unit() only once in mixer_init().
christos added a commit: rG69707d9f5091: sound: Call device_get_name() and device_get_unit() only once in mixer_init().May 17 2024, 7:31 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
12 lines

Diff 137337

View Options

sys/dev/sound/pcm/mixer.c

Loading...