acl_to_text: include sys/param.h for MAXLOGNAME
ClosedPublic
Actions

Authored by brooks on Mar 22 2024, 8:26 PM.

Tags

None

Referenced Files

	F167902421: D44474.id137070.diff
	Tue, Aug 25, 8:43 AM

	F167896483: D44474.id.diff
	Tue, Aug 25, 7:53 AM

	F167895585: D44474.id136966.diff
	Tue, Aug 25, 7:46 AM

	F167878157: D44474.diff
	Tue, Aug 25, 5:04 AM

	Unknown Object (File)
	Mon, Aug 24, 4:13 AM

	Unknown Object (File)
	Sat, Aug 22, 11:24 PM

	Unknown Object (File)
	Sat, Aug 22, 3:57 AM

	Unknown Object (File)
	Thu, Aug 20, 9:01 AM

View All Files

Subscribers

imp

Details

Reviewers

kib
imp
trasz

Commits

rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 57067
Build 53955: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 22 2024, 8:26 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2024, 8:26 PM

brooks requested review of this revision.Mar 22 2024, 8:26 PM

Harbormaster completed remote builds in B56745: Diff 136103.Mar 22 2024, 8:26 PM

brooks added a child revision: D44468: sys/acl.h: reduce header pollution.Mar 22 2024, 8:27 PM

brooks added reviewers: kib, imp, trasz.

kib added inline comments.Mar 23 2024, 6:57 AM

lib/libc/posix1e/acl_to_text.c
32–33	Since sys/param.h includes so many other stuff which might better be namespaced, I suggest to add namespace.h before its inclusion.

namespace sys/param.h

Harbormaster completed remote builds in B57067: Diff 136966.Apr 12 2024, 9:48 PM

kib accepted this revision.Apr 12 2024, 11:33 PM

This revision is now accepted and ready to land.Apr 12 2024, 11:33 PM

Closed by commit rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME (authored by brooks). · Explain WhyApr 15 2024, 8:44 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME.

Revision Contents
Changeset List

Path

Size

lib/

libc/

posix1e/

acl_to_text.c

2 lines

Diff 136966

View Options

lib/libc/posix1e/acl_to_text.c

acl_to_text: include sys/param.h for MAXLOGNAMEClosedPublicActions