Page MenuHomeFreeBSD
Differential D44753

fattime: make the test code build again
ClosedPublic
Actions

Authored by jeffpc_josefsipek.net on Apr 12 2024, 2:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 21, 2:10 AM
Unknown Object (File)
Thu, Dec 18, 7:22 PM
Unknown Object (File)
Tue, Dec 16, 3:40 AM
Unknown Object (File)
Thu, Dec 11, 1:35 PM
Unknown Object (File)
Wed, Nov 26, 1:07 AM
Unknown Object (File)
Nov 23 2025, 6:20 PM
Unknown Object (File)
Nov 8 2025, 6:07 PM
Unknown Object (File)
Oct 19 2025, 8:55 PM
View All 77 Files
Subscribers
imp
olce

Details

Reviewers
phk
imp
Group Reviewers
Contributor Reviews (src)
Commits
rG7b8b613d08d0: fattime: make the test code build again
Summary

This change...

  1. replaces calls to timet2fattime/fattime2timet with calls to timespec2fattime/fattime2timespec. The functions got renamed shortly after they landed in the kernel but the test code wasn't updated (see 7ea93e912bf0ef).
  2. adds a utc_offset stub.

With this, the test code builds and runs as a 32-bit binary (cc -Wall -O2
-m32 subr_fattime.c).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57043
Build 53931: arc lint + arc unit

Event Timeline

jeffpc_josefsipek.net created this revision.Apr 12 2024, 2:57 AM
Herald added subscribers: olce, imp. · View Herald TranscriptApr 12 2024, 2:57 AM
jeffpc_josefsipek.net requested review of this revision.Apr 12 2024, 2:57 AM
Harbormaster completed remote builds in B57043: Diff 136913.Apr 12 2024, 2:57 AM
jeffpc_josefsipek.net edited the summary of this revision. (Show Details)Apr 12 2024, 1:30 PM
jeffpc_josefsipek.net edited the summary of this revision. (Show Details)Apr 12 2024, 1:37 PM
jeffpc_josefsipek.net added a reviewer: phk.Apr 12 2024, 1:42 PM
jeffpc_josefsipek.net added a child revision: D44754: fattime: make the test code check beyond 32-bit time_t limits.Apr 12 2024, 11:22 PM
jeffpc_josefsipek.net added a reviewer: Contributor Reviews (src).Apr 13 2024, 2:12 AM
imp added inline comments.Apr 13 2024, 3:14 PM
sys/kern/subr_fattime.c
301

why 1?

jeffpc_josefsipek.net added inline comments.Apr 13 2024, 4:13 PM
sys/kern/subr_fattime.c
301

I'm not happy with hardcoding 1 like this, but...

  1. the original test code assumed UTC (the subsequent change that renamed the functions (and broke the test) also added the int utc arg) and using 1 keeps the test UTC-based (not that it matters since the stub for utc_offset() always returns 0)
  2. the arg is int, so it seems wrong to use anything other than 0 or 1.
imp accepted this revision.Apr 28 2024, 8:48 PM
This revision is now accepted and ready to land.Apr 28 2024, 8:48 PM
Closed by commit rG7b8b613d08d0: fattime: make the test code build again (authored by jeffpc_josefsipek.net, committed by tsoome). · Explain WhyMay 1 2024, 7:53 AM
This revision was automatically updated to reflect the committed changes.
tsoome added a commit: rG7b8b613d08d0: fattime: make the test code build again.

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines

Diff 136913

View Options

sys/kern/subr_fattime.c

Loading...