Page MenuHomeFreeBSD
Differential D44694

Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup)
ClosedPublic
Actions

Authored by michaelo on Apr 9 2024, 10:09 AM.
Tags
None
Referenced Files
F167710611: D44694.id.diff
Sun, Aug 23, 10:02 PM
F167700190: D44694.diff
Sun, Aug 23, 8:50 PM
Unknown Object (File)
Sat, Aug 22, 3:07 AM
Unknown Object (File)
Mon, Aug 17, 1:19 PM
Unknown Object (File)
Thu, Aug 13, 3:08 AM
Unknown Object (File)
Wed, Aug 12, 9:53 PM
Unknown Object (File)
Wed, Aug 12, 4:10 AM
Unknown Object (File)
Wed, Aug 12, 3:57 AM
View All Files
Subscribers
None

Details

Reviewers
jrm
otis
rene
Group Reviewers
portmgr
Commits
R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup)
Summary

Approved by: jrm (mentor), otis (mentor)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56980
Build 53868: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Apr 9 2024, 10:09 AM
michaelo created this revision.
Harbormaster completed remote builds in B56980: Diff 136764.Apr 9 2024, 10:09 AM
otis requested changes to this revision.Apr 9 2024, 10:21 AM
otis added inline comments.
Mk/Scripts/do-users-groups.sh
205

Let's be more consistent and not use ending dots at all.

This revision now requires changes to proceed.Apr 9 2024, 10:21 AM
michaelo added inline comments.Apr 9 2024, 10:24 AM
Mk/Scripts/do-users-groups.sh
205

No issue then I will invert my patch.

michaelo updated this revision to Diff 136768.Apr 9 2024, 10:33 AM

Remove trailing period

Harbormaster completed remote builds in B56984: Diff 136768.Apr 9 2024, 10:34 AM
otis accepted this revision.Apr 9 2024, 10:44 AM

LGTM

This revision is now accepted and ready to land.Apr 9 2024, 10:44 AM
jrm accepted this revision.Apr 9 2024, 1:54 PM

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

jrm added a reviewer: portmgr.Apr 9 2024, 2:34 PM
michaelo added a comment.Apr 9 2024, 3:38 PM
In D44694#1019044, @jrm wrote:

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

Thanks Joe, looking forward to.

rene accepted this revision.Apr 10 2024, 6:23 PM
Closed by commit R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup) (authored by michaelo). · Explain WhyApr 10 2024, 7:04 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
8 lines

Diff 136764

View Options

Mk/Scripts/do-users-groups.sh

Loading...