Page MenuHomeFreeBSD
Differential D44694

Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup)
ClosedPublic
Actions

Authored by michaelo on Tue, Apr 9, 10:09 AM.
Tags
None
Referenced Files
F82767928: D44694.id136870.diff
Thu, May 2, 10:36 AM
Unknown Object (File)
Sun, Apr 28, 4:50 AM
Unknown Object (File)
Fri, Apr 26, 4:55 AM
Unknown Object (File)
Sat, Apr 20, 2:48 AM
Unknown Object (File)
Sat, Apr 13, 9:26 PM
Unknown Object (File)
Fri, Apr 12, 1:47 AM
Unknown Object (File)
Thu, Apr 11, 6:02 PM
Unknown Object (File)
Thu, Apr 11, 5:15 PM
View All 10 Files
Subscribers
None

Details

Reviewers
jrm
otis
rene
Group Reviewers
portmgr
Commits
R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup)
Summary

Approved by: jrm (mentor), otis (mentor)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Tue, Apr 9, 10:09 AM
michaelo created this revision.
Harbormaster completed remote builds in B56980: Diff 136764.Tue, Apr 9, 10:09 AM
otis requested changes to this revision.Tue, Apr 9, 10:21 AM
otis added inline comments.
Mk/Scripts/do-users-groups.sh
205

Let's be more consistent and not use ending dots at all.

This revision now requires changes to proceed.Tue, Apr 9, 10:21 AM
michaelo added inline comments.Tue, Apr 9, 10:24 AM
Mk/Scripts/do-users-groups.sh
205

No issue then I will invert my patch.

michaelo updated this revision to Diff 136768.Tue, Apr 9, 10:33 AM

Remove trailing period

Harbormaster completed remote builds in B56984: Diff 136768.Tue, Apr 9, 10:34 AM
otis accepted this revision.Tue, Apr 9, 10:44 AM

LGTM

This revision is now accepted and ready to land.Tue, Apr 9, 10:44 AM
jrm accepted this revision.Tue, Apr 9, 1:54 PM

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

jrm added a reviewer: portmgr.Tue, Apr 9, 2:34 PM
michaelo added a comment.Tue, Apr 9, 3:38 PM
In D44694#1019044, @jrm wrote:

LGTM However, someone from portmgr should approve. I'll try to get someone to look today.

Thanks Joe, looking forward to.

rene accepted this revision.Wed, Apr 10, 6:23 PM
Closed by commit R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup) (authored by michaelo). · Explain WhyWed, Apr 10, 7:04 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:3887897fbaa0: Mk/Scripts/do-users-groups.sh: Make message endings consistent (cleanup).

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
22 lines

Diff 136870

View Options

Mk/Scripts/do-users-groups.sh

Loading...