Page MenuHomeFreeBSD
Differential D44474

acl_to_text: include sys/param.h for MAXLOGNAME
ClosedPublic
Actions

Authored by brooks on Mar 22 2024, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 10, 4:46 AM
Unknown Object (File)
Tue, Feb 10, 4:46 AM
Unknown Object (File)
Mon, Feb 9, 1:11 AM
Unknown Object (File)
Fri, Jan 30, 3:42 PM
Unknown Object (File)
Thu, Jan 29, 4:44 AM
Unknown Object (File)
Wed, Jan 28, 10:03 PM
Unknown Object (File)
Wed, Jan 28, 6:32 PM
Unknown Object (File)
Tue, Jan 27, 5:29 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
imp
trasz
Commits
rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56745
Build 53633: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 22 2024, 8:26 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 22 2024, 8:26 PM
brooks requested review of this revision.Mar 22 2024, 8:26 PM
Harbormaster completed remote builds in B56745: Diff 136103.Mar 22 2024, 8:26 PM
brooks added a child revision: D44468: sys/acl.h: reduce header pollution.Mar 22 2024, 8:27 PM
brooks added reviewers: kib, imp, trasz.
kib added inline comments.Mar 23 2024, 6:57 AM
lib/libc/posix1e/acl_to_text.c
33

Since sys/param.h includes so many other stuff which might better be namespaced, I suggest to add namespace.h before its inclusion.

brooks updated this revision to Diff 136966.Apr 12 2024, 9:47 PM
  • namespace sys/param.h
Harbormaster completed remote builds in B57067: Diff 136966.Apr 12 2024, 9:48 PM
kib accepted this revision.Apr 12 2024, 11:33 PM
This revision is now accepted and ready to land.Apr 12 2024, 11:33 PM
Closed by commit rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME (authored by brooks). · Explain WhyApr 15 2024, 8:44 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG418b4c2a80a2: acl_to_text: include sys/param.h for MAXLOGNAME.

Revision Contents
Changeset List

PathSize
lib/
libc/
posix1e/
2 lines

Diff 136103

View Options

lib/libc/posix1e/acl_to_text.c

Loading...