param.h
ClosedPublic
Actions

Authored by brooks on Mar 21 2024, 11:39 PM.

Details

Reviewers

kib
imp
trasz

Commits

rGb83d3eb5b798: sys/_{cpu,domain}set.h: don't require sys/param.h

Summary

Add machine/param.h for MAXCPU and MAXMEMDOM in the _KERNEL case of
sys/_cpuset.h and sys/_domainset.h, making them more self contained.

This eliminates the need to include sys/param.h before sys/cpuset.h and
sys/domainset.h.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56732
Build 53620: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Mar 21 2024, 11:39 PM

brooks created this revision.

brooks added a parent revision: D44465: Reduce reliance on sys/sysproto.h pollution.

Harbormaster completed remote builds in B56732: Diff 136054.Mar 21 2024, 11:39 PM

brooks added a child revision: D44467: sysproto.h: sys/acl.h -> sys/types.h.Mar 21 2024, 11:39 PM

Alternatively we could require that consumers include sys/param.h and then only the the !RCTL case in sys/kern/kern_rctl.c needs changing, but this seems tidier.

kib accepted this revision.Mar 22 2024, 3:17 AM

This revision is now accepted and ready to land.Mar 22 2024, 3:17 AM

Closed by commit rGb83d3eb5b798: sys/_{cpu,domain}set.h: don't require sys/param.h (authored by brooks). · Explain WhyApr 15 2024, 8:44 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGb83d3eb5b798: sys/_{cpu,domain}set.h: don't require sys/param.h.

Revision Contents
Changeset List

Path

Size

sys/

_cpuset.h

2 lines

_domainset.h

2 lines

Diff 136054

View Options

sys/sys/_cpuset.h