Page MenuHomeFreeBSD

Allwinner A20 HDMI support
ClosedPublic

Authored by jmcneill_invisible.ca on Feb 21 2016, 9:33 PM.
Tags
Referenced Files
Unknown Object (File)
Nov 12 2024, 4:38 AM
Unknown Object (File)
Nov 10 2024, 11:29 PM
Unknown Object (File)
Oct 28 2024, 10:59 PM
Unknown Object (File)
Oct 22 2024, 11:58 AM
Unknown Object (File)
Oct 21 2024, 11:18 PM
Unknown Object (File)
Oct 5 2024, 11:25 PM
Unknown Object (File)
Oct 2 2024, 11:12 PM
Unknown Object (File)
Sep 30 2024, 9:23 PM
Subscribers

Details

Reviewers
andrew
Group Reviewers
ARM
Commits
rS296064: Add Allwinner A20 HDMI support.
Summary

Support for the HDMI transmitter on the Allwinner A20 SoC. Features DDC/EDID and audio support.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jmcneill_invisible.ca retitled this revision from to Allwinner A20 HDMI support.
jmcneill_invisible.ca updated this object.
jmcneill_invisible.ca edited the test plan for this revision. (Show Details)
jmcneill_invisible.ca added a reviewer: ARM.
jmcneill_invisible.ca set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill_invisible.ca added a project: ARM.
sys/arm/allwinner/a10_fb.c
180

Why M_NOWAIT?

436

Should this be under bootverbose?

sys/arm/allwinner/a10_hdmi.c
200

Why an array?

248

if ((hpd & HPD_DET) == HPD_DET)

390
return ((edid[CEA_DTD] & DTD_BASIC_AUDIO) == DTD_BASIC_AUDIO)

or

return ((edid[CEA_DTD] & DTD_BASIC_AUDIO) != 0)
sys/arm/allwinner/a10_hdmiaudio.c
53

tab

70

This line looks quite wide, is it past 80 characters?

372

Where did this number come from? (131072 == 0x20000)

sys/arm/allwinner/files.allwinner
22–24

Are these a10 specific?

sys/boot/fdt/dts/arm/sun7i-a20-hdmi.dtsi
31–46

Where did these compat strings come from?

sys/arm/allwinner/a10_fb.c
180

It's a lot of memory and it needs to be physically contiguous (and no GART or IOMMU as far as I can tell). If the HDMI cable is plugged in some time after boot, memory may be fragmented and can fail.

The alternative is to reserve memory early at boot to account for the largest possible framebuffer. Not sure what the top end should be if we want to support hotplug (DEBE can support up to 8Kx8K layers -- a single layer at 32bpp would be 256MB!).

436

You're right, I'll fix it.

sys/arm/allwinner/a10_hdmi.c
200

No specific reason, I will fix it.

sys/arm/allwinner/a10_hdmiaudio.c
372

I pulled it out of the air. Will update this to use pcm_getbuffersize.

sys/arm/allwinner/files.allwinner
22–24

a10_fb.c: a10, a20, a31, and a80 share the same display engine. Later SoCs (e.g. a83t) are different (datasheet refers to it as "DE2.0").

a10_hdmi.c: a10/a20 have the same hdmi ("HDMI 1.3") block. a31 has a block that is mostly the same ("HDMI 1.4") with a different DDC interface and a few other minor changes. Later SoCs (a80, a83t, etc) have something completely different (not documented in the datasheet).

sys/boot/fdt/dts/arm/sun7i-a20-hdmi.dtsi
31–46

I made them up, they are not in Linux mainline and the vendor tree doesn't use FDT.

  • Hide edid_print with bootverbose
  • Fix size of struct resource * array in a10fb_softc
  • No need for struct resource * array in a10hdmi_softc
  • Style fixes
  • Use pcm_getbuffersize to determine a10hdmiaudio DMA buffer size
andrew added a reviewer: andrew.
This revision is now accepted and ready to land.Feb 25 2016, 11:01 AM
This revision was automatically updated to reflect the committed changes.