/: properly depend on Maven package
ClosedPublic
Actions

Authored by michaelo on Mar 5 2024, 3:26 PM.

Details

Reviewers

jrm
otis
vvd
yuri

Commits

R11:90e44770f550: */*: properly depend on Maven package

Summary

devel/maven and devel/maven39 do not provide mvn(1) from LOCALBASE that
one comes from devel/maven-wrapper instead. Therefore, one should depend
on the package rather than a non-existing executable/script.

Approved by: jrm (mentor), otis (mentor), vvd, yuri

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56451
Build 53339: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Mar 5 2024, 3:26 PM

michaelo created this revision.

Harbormaster completed remote builds in B56450: Diff 135412.Mar 5 2024, 3:26 PM

michaelo mentioned this in D44153: java/eclipse: prevent conflict install devel/git@lite if devel/git already installed.Mar 5 2024, 3:27 PM

I think you can add java/eclipse here too.
Probably https://reviews.freebsd.org/D44153 isn't actual anymore.

In D44229#1008960, @vvd wrote:

I think you can add java/eclipse here too.
Probably https://reviews.freebsd.org/D44153 isn't actual anymore.

Alright, will do. I intentionally didn't touch it because you were working on.

Include java/eclipse

Harbormaster completed remote builds in B56451: Diff 135413.Mar 5 2024, 4:37 PM

lgtm

This revision is now accepted and ready to land.Mar 5 2024, 5:56 PM

FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.

http://pkg.ftfl.ca/data/15amd64-default/2024-03-05_13h23m40s/logs/errors/eclipse-4.24_2.log

It doesn't seem like this change should have any effect, but can you verify this?

It looks good on 14.0 amd64. http://pkg.ftfl.ca/data/14amd64-default/2024-03-05_19h14m11s/logs/eclipse-4.24_2.log

In D44229#1009025, @jrm wrote:

FYI, devel/eclipse failed in my 15.0-CURRENT 1500008 amd64 jail.

http://pkg.ftfl.ca/data/15amd64-default/2024-03-05_13h23m40s/logs/errors/eclipse-4.24_2.log

It doesn't seem like this change should have any effect, but can you verify this?

Not related:

install manually.
===>   eclipse-4.24_2 depends on executable: git - found
===>   Returning to build of eclipse-4.24_2
===>   eclipse-4.24_2 depends on package: maven>0 - not found
===>   Installing existing package /packages/All/maven-3.8.8_1.pkg
[15amd64-default-job-01] Installing maven-3.8.8_1...
[15amd64-default-job-01] `-- Installing maven-wrapper-2...
[15amd64-default-job-01] `-- Extracting maven-wrapper-2: ... done
[15amd64-default-job-01] `-- Installing openjdk8-8.402.06.1_1...

the failure is a heap space shortage:

[INFO] Finished at: 2024-03-05T18:14:56Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:3.0.0-SNAPSHOT:archive-products (archive-products) on project eclipse.platform.repository: Error packing product: Problem creating zip: Execution exception: Java heap space -> [Help 1]
[ERROR]

One needs to set MAVEN_OPTS=-Xmx2G or similar and try again. Could also be just 15 specific.

I don't think I have the right of approval revisions. But I'll set it.

Closed by commit R11:90e44770f550: */*: properly depend on Maven package (authored by michaelo). · Explain WhyMar 11 2024, 9:11 AM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: R11:90e44770f550: */*: properly depend on Maven package.