rtld: unconditionally generate map file during build
ClosedPublic
Actions

Authored by kib on Feb 28 2024, 1:15 AM.

Details

Reviewers

brooks
emaste

Commits

rG5db5c6c87a75: rtld: use generated map file to check for some leaks from libc into rtld
rG799940154c70: rtld: unconditionally generate map file during build

Summary

It is needed at least to ensure that undesirable code is not linked into
rtld from libsys/libc, and adding the map file option each time is not
productive.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Feb 28 2024, 1:15 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 28 2024, 1:15 AM

kib requested review of this revision.Feb 28 2024, 1:15 AM

No objection but I would suggest changing the commit message slightly -- right now it seems to imply that the mere presence of the map file prevents undesired libc/libsys code into rtld, rather than just always having the map file available for the developer to inspect. Or just a comment before the LDFLAGS entry, something like

# Always produce the map file so that may be inspected to confirm undesired
# code is not linked from libsys/libc.

This revision is now accepted and ready to land.Feb 28 2024, 1:54 PM

Incorporate suggested comment.
Automate some checks I intended to have.

This revision now requires review to proceed.Feb 28 2024, 11:43 PM

brooks accepted this revision.Feb 29 2024, 12:24 AM

This revision is now accepted and ready to land.Feb 29 2024, 12:24 AM

Thanks, this makes it more clear why we do this.

You may want to redirect error messages to stderr.

Closed by commit rG799940154c70: rtld: unconditionally generate map file during build (authored by kib). · Explain WhyFeb 29 2024, 1:55 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG799940154c70: rtld: unconditionally generate map file during build.

kib added a commit: rG5db5c6c87a75: rtld: use generated map file to check for some leaks from libc into rtld.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

Makefile

25 lines

Diff 135194

View Options

rtld: unconditionally generate map file during buildClosedPublicActions