loader: we can only env_discard() existing variable
ClosedPublic
Actions

Authored by tsoome on Feb 25 2024, 10:41 PM.

Details

Reviewers

manu
imp

Commits

rG0148ccb95a8d: loader: we can only env_discard() existing variable
rG1b3f4ccb7dd8: loader: we can only env_discard() existing variable

Summary

While dropping nvpair from nvstore, we also remove the corresponding
environment variable. By doing so, we should be careful not to try
to unset non-existing variable.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56238
Build 53126: arc lint + arc unit

Event Timeline

tsoome created this revision.Feb 25 2024, 10:41 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 25 2024, 10:41 PM

Herald added subscribers: dab, delphij, imp. · View Herald Transcript

tsoome requested review of this revision.Feb 25 2024, 10:41 PM

Harbormaster completed remote builds in B56238: Diff 134995.Feb 25 2024, 10:41 PM

imp accepted this revision.Feb 25 2024, 11:06 PM

This revision is now accepted and ready to land.Feb 25 2024, 11:06 PM

Closed by commit rG1b3f4ccb7dd8: loader: we can only env_discard() existing variable (authored by tsoome). · Explain WhyFeb 26 2024, 12:59 PM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rG1b3f4ccb7dd8: loader: we can only env_discard() existing variable.

tsoome added a commit: rG0148ccb95a8d: loader: we can only env_discard() existing variable.Mar 11 2024, 2:14 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

zfs/

zfs.c

8 lines

Diff 134995

View Options

loader: we can only env_discard() existing variableClosedPublicActions