kboot: Implement write support for hostdisk
ClosedPublic
Actions

Authored by imp on Feb 21 2024, 10:08 PM.

Details

Reviewers

manu
gleb
kevans
gallatin

Commits

rG7209dd3eba78: kboot: Implement write support for hostdisk
rGb3e76e3d9e22: kboot: Implement write support for hostdisk

Summary

Don't assume that strategy is only called for read. Check the passed
flag for F_READ or F_WRITE and fail if it is neither. Open the disks for
writing and call host_read/host_write depending on that flag.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56159
Build 53047: arc lint + arc unit

Event Timeline

imp created this revision.Feb 21 2024, 10:08 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 21 2024, 10:08 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Feb 21 2024, 10:08 PM

Harbormaster completed remote builds in B56159: Diff 134812.Feb 21 2024, 10:08 PM

imp edited the test plan for this revision. (Show Details)Feb 21 2024, 10:11 PM

imp added reviewers: gleb, kevans.

imp added inline comments.

stand/kboot/kboot/hostdisk.c
318	deleting this debugging is intentional.

gallatin accepted this revision.Feb 21 2024, 11:18 PM

This revision is now accepted and ready to land.Feb 21 2024, 11:18 PM

Ah, yeah, that'd definitely do it...

Closed by commit rGb3e76e3d9e22: kboot: Implement write support for hostdisk (authored by imp). · Explain WhyFeb 22 2024, 4:32 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGb3e76e3d9e22: kboot: Implement write support for hostdisk.

imp added a commit: rG7209dd3eba78: kboot: Implement write support for hostdisk.Apr 16 2024, 8:14 PM

Revision Contents
Changeset List

Path

Size

stand/

kboot/

hostdisk.c

15 lines

Diff 134812

View Options

stand/kboot/kboot/hostdisk.c

kboot: Implement write support for hostdiskClosedPublicActions