Differential D5131

Remove taskqueue_enqueue_fast from the tree
ClosedPublic
Actions

Authored by howard0su_gmail.com on Jan 30 2016, 1:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 28, 3:15 PM

	Unknown Object (File)
	Sun, Feb 16, 8:05 PM

	Unknown Object (File)
	Jan 31 2025, 7:24 AM

	Unknown Object (File)
	Jan 14 2025, 9:23 AM

	Unknown Object (File)
	Jan 3 2025, 4:00 PM

	Unknown Object (File)
	Dec 10 2024, 12:17 AM

	Unknown Object (File)
	Dec 5 2024, 12:27 PM

	Unknown Object (File)
	Nov 22 2024, 11:49 AM

View All 90 Files

Subscribers

Details

Reviewers

jhb
sepherosa_gmail.com

Group Reviewers

Commits

rS296272: Remove taskqueue_enqueue_fast().

Summary

taskqueue_enqueue_fast is an alias of taskqueue_enqueue. It is not
needed to _fast version when in interrupt context anymore. Remove all
consumers of taskqueue_enqueue_fast and remove it from taskqueue.h.
But leave the implementation in kern/subr_taskqueue.c for back-
compability of binary drivers.

Also update man page to remove the related description on
taskqueue_enqueue_fast.

Point By: jhb

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2563
Build 2580: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 12865.Jan 30 2016, 1:14 PM

howard0su_gmail.com retitled this revision from to Remove taskqueue_enqueue_fast from the tree.

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

howard0su_gmail.com added a reviewer: jhb.

Herald added a reviewer: manpages. · View Herald TranscriptJan 30 2016, 1:14 PM

Herald added subscribers: andrew, imp. · View Herald Transcript

howard0su_gmail.com added a reviewer: sepherosa_gmail.com.Feb 14 2016, 9:08 AM

I'll see if I can't do a tinderbox build of this and commit it.

This revision is now accepted and ready to land.Feb 18 2016, 5:42 PM

Remove enqueue_fast from Makefile of manpages.

This revision now requires review to proceed.Feb 19 2016, 3:54 AM

Herald edited edge metadata. · View Herald TranscriptFeb 19 2016, 3:54 AM

hyperv/hn bits have been committed. You probably need to leave it out.

This revision is now accepted and ready to land.Feb 19 2016, 3:58 AM

Closed by commit rS296272: Remove taskqueue_enqueue_fast(). (authored by jhb). · Explain WhyMar 1 2016, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

1 line

20 lines

sys/

arm/

ti/

am335x/

am335x_dmtpps.c

2 lines

dev/

aac/

2 lines

ath/

if_ath_sysctl.c

2 lines

bwn/

2 lines

bxe/

8 lines

drm2/

drm_fb_helper.c

2 lines

hyperv/

netvsc/

hv_netvsc_drv_freebsd.c

6 lines

vmbus/

hv_connection.c

2 lines

malo/

4 lines

nfe/

4 lines

oce/

4 lines

re/

4 lines

smc/

16 lines

vr/

2 lines

xen/

netfront/

4 lines

netpfil/

ipfw/

2 lines

sys/

1 line

x86/

iommu/

2 lines

2 lines

x86/

6 lines

Diff 13474

share/man/man9/Makefile

Loading...

share/man/man9/taskqueue.9

Loading...

sys/arm/ti/am335x/am335x_dmtpps.c

Loading...

sys/dev/aac/aac.c

Loading...

sys/dev/ath/if_ath_sysctl.c

Loading...

sys/dev/bwn/if_bwn.c

Loading...

sys/dev/bxe/bxe.c

Loading...

sys/dev/drm2/drm_fb_helper.c

Loading...

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Loading...

sys/dev/hyperv/vmbus/hv_connection.c

Loading...

sys/dev/malo/if_malo.c

Loading...

sys/dev/nfe/if_nfe.c

Loading...

sys/dev/oce/oce_if.c

Loading...

sys/dev/re/if_re.c

Loading...

sys/dev/smc/if_smc.c

Loading...

sys/dev/vr/if_vr.c

Loading...

sys/dev/xen/netfront/netfront.c

Loading...

sys/netpfil/ipfw/ip_dummynet.c

Loading...

sys/sys/taskqueue.h

Loading...

sys/x86/iommu/intel_fault.c

Loading...

sys/x86/iommu/intel_qi.c

Loading...

sys/x86/x86/mca.c

Loading...