netlink: Don't use a zero-length array
ClosedPublic
Actions

Authored by jhb on Feb 15 2024, 12:16 AM.

Details

Reviewers

jrtc27
melifaro

Commits

rG794517a0f379: netlink: Don't use a zero-length array
rG69945c49fea7: netlink: Don't use a zero-length array

Summary

Define SNL_DECLARE_FIELD_PARSER* macros to create a parser that has
no output attributes only input fields and use this to define the
snl_donemsg_parser.

This removes the need for the zero-length nla_p_donemsg[] variable.
Zero length arrays are not valid in ISO C.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56039
Build 52928: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 15 2024, 12:16 AM

Herald added subscribers: glebius, imp. · View Herald TranscriptFeb 15 2024, 12:16 AM

jhb requested review of this revision.Feb 15 2024, 12:16 AM

Harbormaster completed remote builds in B56039: Diff 134377.Feb 15 2024, 12:16 AM

jrtc27 added inline comments.Feb 15 2024, 12:31 AM

sys/netlink/netlink_snl.h
189	I can't obviously see a reason why out_size wouldn't be useful for a field-only parser. Both snl_field_parser and snl_attr_parser have callbacks that take the target allocated based on out_size. Also field generally becomes before attr in the file AFAICT, so would suggest moving this code to line 176.